Comment on attachment 8960974 [details] [diff] [review] rel-25.patch Review of attachment 8960974 [details] [diff] [review]: ----------------------------------------------------------------- - commit message: OK - less than 20 commits: OK - try: OK - manual test: OK, but one regression (maybe from https://github.com/devtools-html/debugger.html/commit/dd18727c137a696e6a52946650e4b8efe4acbdf6 ?). When selecting another tool and switching back to the debugger, the scroll position is lost. If this is not already tracked, we should file an issue. - readme: OK

talos ongoing: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=4118937fde108cebc7138ecd45ad3d5849452b7a&newProject=try&newRevision=7ece888ace2bd967c0377cbb7de01f8016c1be5e&framework=1

Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e21a2a57d05d Update Debugger Frontend v25. r=jdescottes

Previous talos push was on a temporary changeset which made the build fail. New talos: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=eb821fba7e6079bde3da14f8db57356462715a8a&newProject=try&newRevision=42c1ca4d5b5edd84cebb17dfa232a826e9033ee8&framework=1

slight perf regression on complicated debugger open https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=eb821fba7e6079bde3da14f8db57356462715a8a&newProject=try&newRevision=42c1ca4d5b5edd84cebb17dfa232a826e9033ee8&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&showOnlyConfident=1&framework=1