Closed
Bug 1447121
Opened 7 years ago
Closed 7 years ago
Clean up nsImageFrame::ShouldDisplaySelection a bit
Categories
(Core :: Layout: Images, Video, and HTML Frames, enhancement)
Core
Layout: Images, Video, and HTML Frames
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: adrian17, Assigned: adrian17)
References
Details
Attachments
(1 file)
- most of the code is behind an always-on macro from 2003
- confused comments from 2006
- the function would need to be touched for bug 1387143 anyway
Patch coming.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → adrian.wielgosik
Status: NEW → ASSIGNED
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8960344 [details]
Bug 1447121 - Clean up ShouldDisplaySelection, convert it to use Selection and nsRange.
https://reviewboard.mozilla.org/r/229096/#review235424
::: layout/generic/nsImageFrame.cpp
(Diff revision 1)
> #include "nsDisplayList.h"
> #include "nsIContent.h"
> #include "nsIDocument.h"
> #include "FrameLayerBuilder.h"
> -#include "nsISelectionController.h"
> -#include "nsISelection.h"
You need to include mozilla/dom/Selection.h instead, right?
::: layout/generic/nsImageFrame.cpp
(Diff revision 1)
> #include "imgIContainer.h"
> #include "imgLoader.h"
> #include "imgRequestProxy.h"
>
> #include "nsCSSFrameConstructor.h"
> -#include "nsIDOMRange.h"
And mozilla/dom/Range.h
r=me with those fixed.
Attachment #8960344 -
Flags: review?(bzbarsky) → review+
Comment hidden (mozreview-request) |
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86d2f7875bcc
Clean up ShouldDisplaySelection, convert it to use Selection and nsRange. r=bz
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•