Closed
Bug 1447382
Opened 7 years ago
Closed 7 years ago
Debugger release v19.3 for FF60 Beta
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(firefox60 fixed, firefox61 unaffected)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
firefox61 | --- | unaffected |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
jlast
:
review+
jcristau
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jlast
:
review+
jcristau
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d006e03b517b3a22eafb722c9412fb29de15f90
branch https://github.com/devtools-html/debugger.html/tree/release-19-3
compare https://github.com/devtools-html/debugger.html/compare/release-19-2...release-19-3
Contains 3 backports of m-c changes that landed in Firefox 60 between 19.2 and FF60_NIGHTLY_END.
Included 7 debugger.html commits cherry picked from master to the release branch:
- Prevent items[selectedIndex] error (#5517)
https://github.com/devtools-html/debugger.html/commit/14ab3b28519b89160b342b2a66dc0de8681842e9
- [Editor] Prevent multiple search boxes from opening on Windows (#5569)
https://github.com/devtools-html/debugger.html/commit/c42e3f3b72b92824624f6d14b3e07e0ed553d3f6
- Removes sad face when source+goto (#5444)
https://github.com/devtools-html/debugger.html/commit/ff59534df48a064757c057f008034c5917ae42a3
- fix tabs using the selected source (#5535)
https://github.com/devtools-html/debugger.html/commit/c19ae46247cf77592b443bd6c675d6004229c4d6
- Give command bar buttons full background on hover (#5548)
https://github.com/devtools-html/debugger.html/commit/69f3a2afc76fa402971a60ffe20a41c20178c651
- Highlight original source for sources tree (#5511)
https://github.com/devtools-html/debugger.html/commit/abf2574312ca16eec6407a95833622cb235606c4
- Restores result count for Project Search (#5536)
https://github.com/devtools-html/debugger.html/commit/40e4a3349772fe08804cf67aeaf214c390f6efac
Excluded 1 changeset for containing l10n changes:
- Display message to indicate no selected source in Outline tab (#5266) (#5506)
https://github.com/devtools-html/debugger.html/commit/86b80951fdc85a8f4329d576ee7dda795dec91ec
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8960694 -
Attachment is obsolete: true
Attachment #8960804 -
Flags: review?(jlaster)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8960805 -
Flags: review?(jlaster)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8960805 -
Attachment is obsolete: true
Attachment #8960805 -
Flags: review?(jlaster)
Attachment #8960806 -
Flags: review?(jlaster)
Comment 6•7 years ago
|
||
Comment on attachment 8960804 [details] [diff] [review]
dbg-v19.3-part1-realign-bundle.patch
Review of attachment 8960804 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. I checked the bundle and the diff is moving around individual modules in the bundle, but not actually changing the content of the modules or behavior of the debugger.
Attachment #8960804 -
Flags: review?(jlaster) → review+
Comment 7•7 years ago
|
||
Comment on attachment 8960806 [details] [diff] [review]
dbg-v19.3-part2-update-bundle.patch
Review of attachment 8960806 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. I tested each of the bug fixes and they're now fixed.
Attachment #8960806 -
Flags: review?(jlaster) → review+
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8960804 [details] [diff] [review]
dbg-v19.3-part1-realign-bundle.patch
We would like to uplift some improvements and fixes that didn't make it into the debugger that shipped with FF60. This first changeset has no actual code change, the modules just happen to be sorted differently in the bundles (we haven't figured out why this happens yet).
Approval Request Comment
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: it only affects the debugger and code is just moving around here, not actually changing (generated from the exact same 19.2 branch as the version already in beta)
[String changes made/needed]: none
Attachment #8960804 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 9•7 years ago
|
||
Comment on attachment 8960806 [details] [diff] [review]
dbg-v19.3-part2-update-bundle.patch
Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: fixes several debugger bugs (see list in comment 2)
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: it only affects the debugger
[String changes made/needed]: none
Attachment #8960806 -
Flags: approval-mozilla-beta?
Comment 10•7 years ago
|
||
Comment on attachment 8960804 [details] [diff] [review]
dbg-v19.3-part1-realign-bundle.patch
debugger bugfixes, beta60+
Attachment #8960804 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•7 years ago
|
Attachment #8960806 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 11•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/9452d69547d2
https://hg.mozilla.org/releases/mozilla-beta/rev/1f86e8c381c6
status-firefox60:
--- → fixed
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → unaffected
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•