Closed Bug 1447728 Opened 7 years ago Closed 7 years ago

browser_checkcfgstatus.js shouldn't run under clang-cl

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Version:
3 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox61 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: away, Assigned: away)

References

Details

Attachments

(2 files)

Part 1: Add CC_TYPE to mozinfo
(deleted), patch
ted
: review+
Details | Diff | Splinter Review
Part 2: Skip the CFG test on non-MSVC
(deleted), patch
tjr
: review+
Details | Diff | Splinter Review
We can solve this with a `d['cc_type'] = substs.get('CC_TYPE')` in mozinfo.json, and change the skip-if:ccov to check the compiler instead.
Attached patch Part 1: Add CC_TYPE to mozinfo (deleted) — — Splinter Review
Assignee: nobody → dmajor
Attachment #8961318 - Flags: review?(core-build-config-reviews)
Attachment #8961322 - Flags: review?(tom)
Attachment #8961318 - Flags: review?(core-build-config-reviews) → review+
Marco, FYI: this will make `cc_type` available within skip-if etc. I will likely be converting some more instances of `ccov` in upcoming bugs.
Attachment #8961322 - Flags: review?(tom) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b92f0d3f5326 Part 1: Add CC_TYPE to mozinfo. r=ted https://hg.mozilla.org/integration/mozilla-inbound/rev/6e87c3e7eaae Part 2: browser_checkcfgstatus.js should only run on MSVC builds. r=tjr
https://hg.mozilla.org/mozilla-central/rev/b92f0d3f5326 https://hg.mozilla.org/mozilla-central/rev/6e87c3e7eaae
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: