Closed
Bug 1447742
Opened 7 years ago
Closed 7 years ago
DLL interceptor doesn't understand clang-cl's movups instructions in 32-bit builds
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
handyman
:
review+
|
Details | Diff | Splinter Review |
No description provided.
| Comment hidden (typo) |
| Comment hidden (typo) |
This is basically copy/pasted from the 64 bit section. If this were a few lines larger I might have thought about sharing the code, but at this point I just can't be bothered. :/
Assignee: nobody → dmajor
Attachment #8961323 -
Flags: review?(davidp99)
Hmm, the hunk around line 1265 is probably some CRLF auto-fixup from my editor.
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8961323 [details] [diff] [review]
movups32
lgtm. I'd nit on the conditional (we normally try to format these as `origBytes[nOrigBytes+1] & 0xfe == 0x10`) but its cut-and-pasted from existing code so thats really a job for a refactor.
Attachment #8961323 -
Flags: review?(davidp99) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe73c0251346
Understand movups in 32-bit DLL interceptor. r=handyman
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•