Closed
Bug 1447839
Opened 7 years ago
Closed 2 years ago
Stop using PathBuilderSkia in PathBuilderRecording
Categories
(Core :: Graphics: WebRender, enhancement, P2)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
(Blocks 4 open bugs)
Details
(Whiteboard: [sp3])
Attachments
(3 files)
We're only using it for implementing CurrentPoint().
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jmuizelaar
|
|
Assignee | |
Comment 1•7 years ago
|
||
I'm wrong. We use it for other methods too. It's probably better to just use the Skia path internally.
|
||
Updated•7 years ago
|
Blocks: stage-wr-trains
Priority: -- → P2
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•2 years ago
|
Severity: normal → S3
|
|
Assignee | |
Comment 2•2 years ago
|
||
Alternatively, we can create and cache the Skia path on demand when needed for the methods that use it.
|
||
Comment 3•2 years ago
|
||
|
|
||
Comment 4•2 years ago
|
||
Depends on D172869
|
||
Updated•2 years ago
|
Attachment #9323640 -
Attachment description: Bug 1447839 - Avoid creating internal path builer for PathRecording unless necessary. r?jrmuizel → Bug 1447839 - Avoid creating internal path builder for PathRecording unless necessary. r?jrmuizel
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03e8e473943d
Avoid creating internal path for PathRecording unless necessary. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/038ecfe701fb
Avoid creating internal path builder for PathRecording unless necessary. r=jrmuizel
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/03e8e473943d
https://hg.mozilla.org/mozilla-central/rev/038ecfe701fb
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
|
|
||
Comment 7•2 years ago
|
||
The math for directly calculating the endpoint of the arc is actually trivial,
and ArcToBezier is pretty expensive so should be avoided.
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/229cb61335bb
Directly calculate endpoint in PathBuilderRecording::Arc. r=jrmuizel,gfx-reviewers
|
||
Comment 9•2 years ago
|
||
| bugherder | ||
|
||
Comment 10•2 years ago
|
||
A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)
|
||
Updated•2 years ago
|
Whiteboard: [sp3]
|
||
Updated•2 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-287
You need to log in
before you can comment on or make changes to this bug.
Description
•