Closed
Bug 1447952
Opened 7 years ago
Closed 6 years ago
Use relative time format in the site data manager
Categories
(Firefox :: Settings UI, enhancement, P3)
Tracking
()
RESOLVED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: johannh, Assigned: mkohler, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [storage-v2])
Attachments
(2 files, 1 obsolete file)
In my opinion, the dates in the site data manager are a little hard to grasp at first sight. We recently added support for RelativeTimeFormat in Gecko: https://groups.google.com/forum/?fromgroups=&hl=en#!topic/firefox-dev/P8ll42qpbZc
That would allow us to go from 04/27/18, 09:36 PM to "five minutes ago" or "2 months ago".
Sounds like an improvement to me!
Reporter | ||
Updated•7 years ago
|
Priority: -- → P3
Whiteboard: [storage-v2][triage] → [storage-v2]
Reporter | ||
Comment 1•7 years ago
|
||
The code that would need to change is here: https://searchfox.org/mozilla-central/rev/4114ad2cfcbc511705c7865a4a34741812f9a2a9/browser/components/preferences/siteDataSettings.js#67
This is how sync displays relative dates (see bug 1184265): https://searchfox.org/mozilla-central/rev/4114ad2cfcbc511705c7865a4a34741812f9a2a9/browser/base/content/browser-sync.js#634-645
Mentor: jhofmann
Updated•7 years ago
|
Assignee: nobody → 1991manish.kumar
Reporter | ||
Comment 2•7 years ago
|
||
Hi Manish, if you're away until May 3rd I would like to give this bug to someone else to be able to land in the 61 timeframe. There's plenty of other bugs to work on later. Are you actively working on this? :)
Thanks!
Flags: needinfo?(1991manish.kumar)
Assignee | ||
Comment 3•7 years ago
|
||
I'd be happy to take over here if Manish is not working on it.
Reporter | ||
Comment 4•7 years ago
|
||
I think we can go ahead here, the patch for this shouldn't be too complex either I hope :)
Thanks!
Assignee: 1991manish.kumar → me
Status: NEW → ASSIGNED
Flags: needinfo?(1991manish.kumar)
Assignee | ||
Comment 6•7 years ago
|
||
I will be able to take a look this weekend. Is that okay? I'm happy to give this to someone else if there is somebody who can do it before that :)
Flags: needinfo?(me)
Comment 7•7 years ago
|
||
Assignee | ||
Comment 8•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(jhofmann)
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(jhofmann)
Comment 9•7 years ago
|
||
Assignee | ||
Comment 10•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(jhofmann)
Comment 11•7 years ago
|
||
Comment on attachment 8974518 [details]
Bug 1447952 - Use relative time format in the site data manager r=johannh
Johann Hofmann [:johannh] has approved the revision.
https://phabricator.services.mozilla.com/D1253
Attachment #8974518 -
Flags: review+
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(jhofmann)
Assignee | ||
Comment 12•7 years ago
|
||
Updated the patch according to comments.
new try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=126451c5f8509ca97eb30a8541b888773596e595
Flags: needinfo?(jhofmann)
Reporter | ||
Comment 13•7 years ago
|
||
This looks good to me but I can't import the patch due to conflicts. Would you mind rebasing on central and setting checkin-needed?
Thanks!
Flags: needinfo?(jhofmann)
Assignee | ||
Comment 14•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Updated•6 years ago
|
Attachment #8973468 -
Attachment is obsolete: true
Comment 15•6 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3172bfa5d63
Use relative time format in the site data manager. r=johannh
Keywords: checkin-needed
Comment 16•6 years ago
|
||
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/638fa8732dca
Backed out changeset c3172bfa5d63 for frequent browser chrome failures on browser_siteData.js. CLOSED TREE
Comment 17•6 years ago
|
||
This was backed out for frequent browser chrome failures on browser_siteData.js.
Here is the range https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-searchStr=browser%20chrome&filter-failure_classification_id=2&tochange=638fa8732dca3cabcd1d13b254ac6f7308d91eb8&fromchange=c3172bfa5d63c410f7016de2b23da1adf8244d12&selectedJob=180749242
Failure log:
https://treeherder.mozilla.org/logviewer.html#?job_id=180749242&repo=mozilla-inbound&lineNumber=17799
https://treeherder.mozilla.org/logviewer.html#?job_id=180748794&repo=mozilla-inbound&lineNumber=1717
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/638fa8732dca3cabcd1d13b254ac6f7308d91eb8
Flags: needinfo?(me)
Updated•6 years ago
|
Attachment #8973468 -
Attachment is obsolete: false
Assignee | ||
Updated•6 years ago
|
Attachment #8974518 -
Attachment is obsolete: true
Flags: needinfo?(me)
Comment 18•6 years ago
|
||
Use relative time format in the site data manager
Assignee | ||
Updated•6 years ago
|
Attachment #8973468 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Attachment #8981658 -
Flags: review?(jhofmann)
Assignee | ||
Comment 19•6 years ago
|
||
So sorry about this. Looks like I completely screwed up the rebase. Johann, would you mind looking at https://phabricator.services.mozilla.com/D1454 to make sure I don't screw up again? This should include all the necessary changes on top of a recent tip. Sorry again!
Assignee | ||
Comment 20•6 years ago
|
||
Comment 21•6 years ago
|
||
Comment on attachment 8981658 [details]
Bug 1447952 - Use relative time format in the site data manager r=johannh
Johann Hofmann [:johannh] has approved the revision.
https://phabricator.services.mozilla.com/D1454
Attachment #8981658 -
Flags: review+
Reporter | ||
Updated•6 years ago
|
Attachment #8981658 -
Flags: review?(jhofmann)
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Comment 22•6 years ago
|
||
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c7e33619bde
Use relative time format in the site data manager. r=johannh
Keywords: checkin-needed
Comment 23•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Updated•6 years ago
|
Flags: qe-verify-
Updated•5 years ago
|
Attachment #8974518 -
Attachment is obsolete: false
You need to log in
before you can comment on or make changes to this bug.
Description
•