Closed Bug 1447952 Opened 7 years ago Closed 6 years ago

Use relative time format in the site data manager

Categories

(Firefox :: Settings UI, enhancement, P3)

60 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: johannh, Assigned: mkohler, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [storage-v2])

Attachments

(2 files, 1 obsolete file)

In my opinion, the dates in the site data manager are a little hard to grasp at first sight. We recently added support for RelativeTimeFormat in Gecko: https://groups.google.com/forum/?fromgroups=&hl=en#!topic/firefox-dev/P8ll42qpbZc That would allow us to go from 04/27/18, 09:36 PM to "five minutes ago" or "2 months ago". Sounds like an improvement to me!
Priority: -- → P3
Whiteboard: [storage-v2][triage] → [storage-v2]
Assignee: nobody → 1991manish.kumar
Hi Manish, if you're away until May 3rd I would like to give this bug to someone else to be able to land in the 61 timeframe. There's plenty of other bugs to work on later. Are you actively working on this? :) Thanks!
Flags: needinfo?(1991manish.kumar)
I'd be happy to take over here if Manish is not working on it.
I think we can go ahead here, the patch for this shouldn't be too complex either I hope :) Thanks!
Assignee: 1991manish.kumar → me
Status: NEW → ASSIGNED
Flags: needinfo?(1991manish.kumar)
Michael, are you still looking at this? :)
Flags: needinfo?(me)
I will be able to take a look this weekend. Is that okay? I'm happy to give this to someone else if there is somebody who can do it before that :)
Flags: needinfo?(me)
Flags: needinfo?(jhofmann)
Flags: needinfo?(jhofmann)
Flags: needinfo?(jhofmann)
Comment on attachment 8974518 [details] Bug 1447952 - Use relative time format in the site data manager r=johannh Johann Hofmann [:johannh] has approved the revision. https://phabricator.services.mozilla.com/D1253
Attachment #8974518 - Flags: review+
Flags: needinfo?(jhofmann)
Flags: needinfo?(jhofmann)
This looks good to me but I can't import the patch due to conflicts. Would you mind rebasing on central and setting checkin-needed? Thanks!
Flags: needinfo?(jhofmann)
Keywords: checkin-needed
Attachment #8973468 - Attachment is obsolete: true
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c3172bfa5d63 Use relative time format in the site data manager. r=johannh
Keywords: checkin-needed
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/638fa8732dca Backed out changeset c3172bfa5d63 for frequent browser chrome failures on browser_siteData.js. CLOSED TREE
Attachment #8973468 - Attachment is obsolete: false
Attachment #8974518 - Attachment is obsolete: true
Flags: needinfo?(me)
Use relative time format in the site data manager
Attachment #8973468 - Attachment is obsolete: true
Attachment #8981658 - Flags: review?(jhofmann)
So sorry about this. Looks like I completely screwed up the rebase. Johann, would you mind looking at https://phabricator.services.mozilla.com/D1454 to make sure I don't screw up again? This should include all the necessary changes on top of a recent tip. Sorry again!
Comment on attachment 8981658 [details] Bug 1447952 - Use relative time format in the site data manager r=johannh Johann Hofmann [:johannh] has approved the revision. https://phabricator.services.mozilla.com/D1454
Attachment #8981658 - Flags: review+
Attachment #8981658 - Flags: review?(jhofmann)
Keywords: checkin-needed
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6c7e33619bde Use relative time format in the site data manager. r=johannh
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Flags: qe-verify-
Attachment #8974518 - Attachment is obsolete: false
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: