Closed Bug 1448001 Opened 7 years ago Closed 6 years ago

Patch apply fail for both partial mar and complete mar

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(thunderbird_esr6065+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 60.0
Tracking Flags:
Tracking Status
thunderbird_esr60 65+ fixed

People

(Reporter: JoeS1, Assigned: rjl)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

removed-files.in cleanups for comm-esr60 - [1/2]
(deleted), patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review
removed-files.in cleanups for comm-esr60 - [2/2]
(deleted), patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review
Seen in http://ftp.mozilla.org/pub/thunderbird/candidates/60.0b1-candidates/build5/ as well as the previous candidate. The partial fails, then the complete mar fails as well Update_verify failed forlinux and win32
This appears to be caused by the changes in Bug 1439860.
Blocks: 1439860
Specifically, the changes to https://searchfox.org/mozilla-central/source/tools/update-packaging/common.sh#146 appear to be incorrect, as `removed-files` isn't processed correctly.
I think we most (all?) of the stuff in https://searchfox.org/comm-central/source/mail/installer/removed-files.in predates the last watershed, so we can remove it. If we do that, I think we might not tickle the code that Bug 1439860 introduced.
Moving since TB doesn't belong in the Firefox build bucket
Product: Firefox Build System → Thunderbird
Target Milestone: --- → Thunderbird 60.0
Version: 60 Branch → unspecified
removed-files.in has been cleaned up in bug 1488138, but that hasn't been uplifted to comm-esr60. It needs to be in order to close bug 1439860. I'll get it into the next esr60 release. beta has shorter removed-files.in already.
Assignee: nobody → rob
Patch applies to comm-esr60 and is an uplift from comm-central. Try run with repackaging: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9886021b29fdda0cdaade458ac6af5facf077292
Attachment #9033977 - Flags: review?(jorgk)
Attachment #9033977 - Flags: approval-comm-esr60?
Patch applies to comm-esr60 and is an uplift from comm-central. Try run with repackaging: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9886021b29fdda0cdaade458ac6af5facf077292
Attachment #9033979 - Flags: review?(jorgk)
Attachment #9033979 - Flags: approval-comm-esr60?
Comment on attachment 9033977 [details] [diff] [review] removed-files.in cleanups for comm-esr60 - [1/2] This is essentially https://hg.mozilla.org/comm-central/rev/4753c8fcb8b6.
Attachment #9033977 - Flags: review?(jorgk)
Attachment #9033977 - Flags: review+
Attachment #9033977 - Flags: approval-comm-esr60?
Attachment #9033977 - Flags: approval-comm-esr60+
Comment on attachment 9033979 [details] [diff] [review] removed-files.in cleanups for comm-esr60 - [2/2] Yes, and this is https://hg.mozilla.org/comm-central/rev/cf4b74f3b01f. We could have uplifted that in the respective bugs. Anyway, I'll get those patches landed.
Attachment #9033979 - Flags: review?(jorgk)
Attachment #9033979 - Flags: review+
Attachment #9033979 - Flags: approval-comm-esr60?
Attachment #9033979 - Flags: approval-comm-esr60+
https://hg.mozilla.org/releases/comm-esr60/rev/20253f7096fd2fa13b90555aec110e3b17b887d4 https://hg.mozilla.org/releases/comm-esr60/rev/120a894821e640eb2cdb37f148de02658c951cdb Rob, can you please supply patches with 8 lines of context: [diff] git = 1 showfunc = 1 unified = 8 That way they're easier to compare.
Status: NEW → RESOLVED
Closed: 6 years ago
status-thunderbird_esr60: --- → fixed
tracking-thunderbird_esr60: --- → 65+
Resolution: --- → FIXED
Oops, I forgot: TB 60.5 ESR.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: