Closed Bug 1448041 Opened 7 years ago Closed 7 years ago

[meta] Convert consumers of UpdatePlaces to PlacesUtils.history.insert(Many) or PlacesTestUtils.addVisits

Categories

(Toolkit :: Places, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61

People

(Reporter: standard8, Unassigned)

References

Details

(Whiteboard: [fxsearch])

+++ This bug was initially created as a clone of Bug #1282770 +++ updatePlaces doesn't have a great API for javascript, thus I'd like to convert its consumers to the new PlacesUtils.history.insert(Many) APIs. alternatively, tests code can use PlacesTestUtils.addVisits, that has an ever more streamlined API. These are the code points http://searchfox.org/mozilla-central/search?q=.updatePlaces%28&path= Though, the following files should not be changed: toolkit/components/places/History.jsm (implementation) toolkit/components/places/tests/PlacesTestUtils.jsm (covered by bug 1272686) toolkit/components/places/tests/unit/test_async_history_api.js (own test) Would also be great to remove the addVisits helper from toolkit/components/places/tests/browser/head.js and replace its usage in those tests with PlacesTestUtils.addVisits
Note: this is a meta bug, I'll be adding the remaining work in bugs this will depend on.
Mentor: mak77
likely also test_updatePlaces_embed.js could stay as is
Depends on: 1448057
Depends on: 1448064
Depends on: 1448081
This is mostly done, there are a few entries left but we can handle those in bug 1354531
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.