Closed Bug 1448178 Opened 7 years ago Closed 7 years ago

Client should be able to catch unknownError packets from actors

Categories

(DevTools :: Framework, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

See bug 1443550. According to :jryans: > when we call the actor > https://searchfox.org/mozilla-central/source/devtools/server/main.js#1780 > and an error occurs, we don't include the actor ID in the packet. > if we did, the client could react.
Comment on attachment 8961595 [details] Bug 1448178 - include actorId in unknown error packet from DevTools server; https://reviewboard.mozilla.org/r/230458/#review236298 Thanks for working on this! It looks good to me. :) I am actually quite surprised this has never come up before now... :S It seems like a very long standing bug as far as I can tell... ::: commit-message-4598a:1 (Diff revision 1) > +Bug 1448178 - include actorId in unknown error packet from DevTools server;r=jryans It might be nice to also mention why this is helpful in the commit message. ::: devtools/server/main.js:1630 (Diff revision 1) > } > } > return null; > }, > > - _unknownError(prefix, error) { > + _unknownError(prefix, error, from) { Many of the actor related functions take `from` (the actor ID) as the first arg, so it might be nice to do the same here... Not really a big deal though, feel free to disagree.
Attachment #8961595 - Flags: review?(jryans) → review+
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a7f56a5f56f7 include actorId in unknown error packet from DevTools server;r=jryans
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: