Closed
Bug 1448446
Opened 7 years ago
Closed 7 years ago
browser/base/content/test/performance/browser_windowopen.js will permfail for DevEdition when Gecko 61 merges to Beta on 2018-04-26
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | + | verified |
People
(Reporter: aryx, Assigned: florian)
References
Details
Attachments
(2 files)
(deleted),
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
central-as-beta simulations (also covers DevEditions) have revealed that browser/base/content/test/performance/browser_windowopen.js permafails for OS X DevEdition opt:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcada7dffac6f3f6ec64d86d00a565495d781996&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&group_state=expanded&selectedJob=169841889
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=169841889&repo=try
TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen.js | unexpected changed rect: ({x1:110, x2:124, y1:46, y2:59, w:15, h:14}), window width: 1280 -
TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen.js | should have 0 unknown flickering areas - Got 1, expected 0
Flags: needinfo?(florian)
Assignee | ||
Comment 1•7 years ago
|
||
I don't think this is related to bug 1443578, it's just that somehow the reload icon height is now identified as taking 14px rather than 13px in devedition.
Attachment #8962106 -
Flags: review?(mconley)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → florian
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
Somehow when rebasing the merge of browser_windowopen_reflows.js and browser_windowopen_flicker.js, the deletion of browser_windowopen_flicker.js got lost. This file is already removed from the browser.ini manifest.
Attachment #8962107 -
Flags: review?(mconley)
Comment 3•7 years ago
|
||
Comment on attachment 8962107 [details] [diff] [review]
remove unused browser_windowopen_flicker.js test file
Review of attachment 8962107 [details] [diff] [review]:
-----------------------------------------------------------------
Whoops - yeah, thanks for removing this.
Attachment #8962107 -
Flags: review?(mconley) → review+
Comment 4•7 years ago
|
||
Comment on attachment 8962106 [details] [diff] [review]
Patch
Review of attachment 8962106 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8962106 -
Flags: review?(mconley) → review+
Reporter | ||
Updated•7 years ago
|
Summary: browser/base/content/test/performance/browser_windowopen.js will permfail for OS X DevEdition when Gecko 61 merges to Beta on 2018-04-26 → browser/base/content/test/performance/browser_windowopen.js will permfail for DevEdition when Gecko 61 merges to Beta on 2018-04-26
Updated•7 years ago
|
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d437fbde070
accept a height of 14px for the reload icon in the browser_windowopen.js exception, r=mconley.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec1fc0649f4e
remove unused browser_windowopen_flicker.js test file, r=mconley.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(florian)
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2d437fbde070
https://hg.mozilla.org/mozilla-central/rev/ec1fc0649f4e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Reporter | ||
Comment 7•7 years ago
|
||
Verified fixed with latest central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3ba256ed5f1c30dc9bf7a3c7897a8b898e4590c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&group_state=expanded
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•