Closed
Bug 1448519
Opened 7 years ago
Closed 7 years ago
Pick up clang-cl bool fix in r328386
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
https://bugs.llvm.org/show_bug.cgi?id=36886
This will fix Win64 debug xpcshell netwerk/test/unit/test_udpsocket_offline.js
The fix got backed out and will need https://reviews.llvm.org/D44876 in order to re-land.
Just a status note, I'm holding off on landing this until I get the test suite fully green, in case we need further clang fixes.
Perf aside, at this point the only testsuite issue remaining is bug 1448976. It may take a while, and it's only an issue with ThinLTO. So this seems like a good time for a new clang revision.
Arbitrary trunk revision chosen by:
* Pick an interesting fix (in this case, Sylvestre's 7.0 -> 7 version renaming)
* Scan history for alarming backouts shortly after it (none)
* Run it through try (green)
Assignee: nobody → dmajor
Attachment #8963726 -
Flags: review?(core-build-config-reviews)
(For the sake of documenting my process, I'll add that I go through all the major sub-repos when selecting a revision, to make sure I get coordinated changes together. E.g. Sylvestre's fix was r328768+328769.)
|
||
Updated•7 years ago
|
Attachment #8963726 -
Flags: review?(core-build-config-reviews) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/669bffb66604
Pick up clang r328769 on Windows. r=mshal
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•6 years ago
|
Version: Version 3 → 3 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•