Henri Sivonen (:hsivonen) (away from Bugzilla until 2023-09-11) Assignee
	Description • 6 years ago

We append as ASCII buffer shorter than 16, so AppendASCIItoUTF16 is an overkill.

	Nika Layzell [:nika] (ni? for response)
	Comment 2 • 6 years ago
mozreview-review

Comment on attachment 8962078 [details]
Bug 1448581 - Use AppendPrintf() in CharacterData::ToCString(). .

https://reviewboard.mozilla.org/r/230916/#review236746

Why don't we just

::: dom/base/CharacterData.cpp:430
(Diff revision 1)
>        } else if (ch == '>') {
>          aBuf.AppendLiteral(">");
>        } else if ((ch < ' ') || (ch >= 127)) {
>          char buf[10];
>          SprintfLiteral(buf, "\\u%04x", ch);
> -        AppendASCIItoUTF16(buf, aBuf);
> +        aBuf.AppendASCII(buf);

It'd be even cleaner if we just `aBuf.AppendPrintf("\\u%04x", ch);`.

	Henri Sivonen (:hsivonen) (away from Bugzilla until 2023-09-11) Assignee
	Comment 4 • 6 years ago
mozreview-review-reply

Comment on attachment 8962078 [details]
Bug 1448581 - Use AppendPrintf() in CharacterData::ToCString(). .

https://reviewboard.mozilla.org/r/230916/#review236746

> It'd be even cleaner if we just `aBuf.AppendPrintf("\\u%04x", ch);`.

Thanks for pointing out the existence of that method! Fixed.

	Pulsebot
	Comment 5 • 6 years ago

Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/729b8eb8a432
Use AppendPrintf() in CharacterData::ToCString(). r=mystor.

	Eliza Balazs [:ebalazs_]
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/729b8eb8a432