Closed
Bug 1448613
Opened 7 years ago
Closed 7 years ago
Clean up TabsInTitlebar resize event handling
Categories
(Firefox :: Tabbed Browser, enhancement)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8962119 [details]
Bug 1448613 - Clean up TabsInTitlebar resize event handling.
https://reviewboard.mozilla.org/r/230960/#review236608
Oh, that looks very good, thank you!
Attachment #8962119 -
Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1bb89af06ba
Clean up TabsInTitlebar resize event handling. r=johannh
|
||
Comment 5•7 years ago
|
||
Backed out changeset a1bb89af06ba (bug 1448613) - expected to fail due to Bug 1446264.
backout: https://hg.mozilla.org/integration/autoland/rev/2924f11425af1640752793b06cf0528189687e45
push backed out: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a1bb89af06bac4d352fb2aca23fbe054a560e94e
Flags: needinfo?(dao+bmo)
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1d8e667912a
Clean up TabsInTitlebar resize event handling. r=johannh
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
|
||
Comment 9•7 years ago
|
||
The resize listener registered here
https://hg.mozilla.org/mozilla-central/rev/b1d8e667912a#l3.24
is not unregistered in uninit:
https://searchfox.org/mozilla-central/source/browser/base/content/browser-tabsintitlebar.js#301
Is that intentional?
Flags: needinfo?(dao+bmo)
|
|
Assignee | |
Comment 10•7 years ago
|
||
That event listener is harmless, it shouldn't be able to leak the window after unload. The removeEventListener call for resolutionchange can be removed too, afaik.
Flags: needinfo?(dao+bmo)
|
|
||
Comment 11•7 years ago
|
||
Thanks. We're porting recent changes in this area to TB and so I noticed. Surely removing both listeners doesn't hurt either.
|
|
Assignee | |
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•