Closed
Bug 1448939
Opened 7 years ago
Closed 7 years ago
Remove mailWindowOverlay.xul
Categories
(Thunderbird :: General, enhancement)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 61.0
People
(Reporter: jorgk-bmo, Assigned: Paenglab)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
It's a huge overlay, ~3800 loc.
|
Assignee | |
Comment 1•7 years ago
|
||
This looks good locally. No deep testing yet. let's do try for us:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7d4a7fee1ab52f915a3fa564a883c6b28e4fbb13
Jörg, I renamed mailWindowOverlay.xul to mainMailToolbox.inc to have still the history somewhere. Is this okay or do you want I kill it and create mainMailToolbox.inc as a new file?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•7 years ago
|
||
Renaming is fine.
|
|
Assignee | |
Comment 3•7 years ago
|
||
A lot of failures. Probably because the tests want to overlay mailWindowOverlay.xul which is removed. Trying now to overlay messenger.xul and messageWindow.xul. On Mac we need maybe to overlay hiddenWindow.xul too. New try:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=5b331357ba4af2c4160de4c346676225a768caa5
|
|
Reporter | |
Comment 4•7 years ago
|
||
I see, the test changes are here:
https://hg.mozilla.org/try-comm-central/rev/5b331357ba4af2c4160de4c346676225a768caa5
|
|
Assignee | |
Comment 5•7 years ago
|
||
This patch should fix the close window test.
The qfb button and the gloda search was shown in the stand alone window. Fixed this too.
Try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c9413a4507e2738a457524fc77d30d58877f042c
Attachment #8962684 -
Attachment is obsolete: true
Attachment #8963813 -
Flags: review?(jorgk)
|
|
Reporter | |
Comment 6•7 years ago
|
||
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/content-tabs/test-content-tab.js | test-content-tab.js::test_content_tab_open
is from bug 1446587, not your fault.
|
|
Reporter | |
Comment 7•7 years ago
|
||
Comment on attachment 8963813 [details] [diff] [review]
mailWindowOverlay.patch
Tests pass, I looked at main window, compose window, address book window, stand-alone window and message source. All look OK.
Attachment #8963813 -
Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2c10998ca9bc
Replace mailWindowOverlay.xul with inlining and pre-processing. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 61.0
You need to log in
before you can comment on or make changes to this bug.
Description
•