Closed
Bug 1449653
Opened 7 years ago
Closed 7 years ago
Implement a dark theme for snippets
Categories
(Firefox :: New Tab Page, enhancement, P2)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox60 | --- | unaffected |
firefox61 | --- | fixed |
firefox62 | --- | fixed |
People
(Reporter: rrosario, Assigned: rrosario)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
Spinoff from bug 1402312.
We need to change the template styles for snippets to use the theme CSS variables and possibly create some new ones.
Updated•7 years ago
|
Severity: normal → enhancement
Iteration: --- → 61.3 - Apr 23
status-firefox60:
--- → unaffected
status-firefox61:
--- → affected
Priority: -- → P2
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → rrosario
Updated•7 years ago
|
Iteration: 61.3 - Apr 23 → 61.4 - May 7
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
snippets-service PR:
https://github.com/mozmeao/snippets-service/pull/385/files
snippets PR:
https://github.com/mozmeao/snippets/pull/144/files
Comment 3•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/b9ac05b84e1e2fbf79a28ea291c0d1aac3cbd58d
Fix Bug 1449653 - Implement a dark theme for snippets
https://github.com/mozilla/activity-stream/commit/e462340ba773a5611f31822e71a4e5b2bed9c56d
Merge pull request #4120 from rlr/Bug1449653/dark-theme
Fix Bug 1449653 - Implement a dark theme for snippets
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•7 years ago
|
||
This isn't quite fixed yet. Only the A-S changes have landed. The changes from comment 2 still need to land.
That said, bug 1456496 is now unblocked.
Updated•7 years ago
|
Iteration: 61.4 - May 7 → 62.1 - May 21
Assignee | ||
Comment 5•7 years ago
|
||
The snippets side patches have been merged:
snippets-service: https://github.com/mozmeao/snippets-service/commit/90611b8da49e5a50a69e7d7a45a411509886952b
snippets: https://github.com/mozmeao/snippets/commit/235b00cb7709a236b0eb80998af6a0214f9b27d3
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Comment 6•7 years ago
|
||
status-firefox62:
--- → fixed
Target Milestone: --- → Firefox 62
Updated•7 years ago
|
Comment 7•6 years ago
|
||
Is this something we should consider backporting to 61?
Flags: needinfo?(rrosario)
Assignee | ||
Comment 8•6 years ago
|
||
This actually is fixed in 61. Not sure why it was set like that? I guess because the bug was closed after 61 went to beta but the client side changes had already landed.
Flags: needinfo?(rrosario)
Target Milestone: Firefox 62 → Firefox 61
Comment 9•6 years ago
|
||
Which bug was that in? Bug 1462427 landed on the 18th AFAICT (after the version bump)?
Flags: needinfo?(rrosario)
Assignee | ||
Comment 10•6 years ago
|
||
From what I can tell, it went in Bug 1457192. There appears to be a bookkeeping bug here.
I see the changes from Comment 3 in https://searchfox.org/mozilla-central/diff/2d7d260a1e6fc94246bf651b364eae3f56a84e08/browser/extensions/activity-stream/css/activity-stream-windows.css#110-111 which is Bug 1457192
Flags: needinfo?(rrosario)
Comment 11•6 years ago
|
||
Thanks for double-checking. Activity Stream patches are indeed a pain to keep track of :(
Comment 12•6 years ago
|
||
Ah indeed. Looks like it was incorrectly associated to the other export as the bug was reopened and only resolved after the snippets changes in comment 5.
https://hg.mozilla.org/mozilla-central/rev/9edd64fc07d3
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•