Closed Bug 1449762 Opened 6 years ago Closed 6 years ago

Incorrect argument to get_logcat(): unexpected keyword argument 'filterOutRegexps'

Categories

(Firefox for Android Graveyard :: Testing, defect)

defect
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

Some calls to ADBDevice.get_logcat() use the wrong keyword argument, resulting in non-fatal errors.

https://treeherder.mozilla.org/logviewer.html#?job_id=170762983&repo=mozilla-inbound&lineNumber=4294

INFO -  Error getting device information: get_logcat() got an unexpected keyword argument 'filterOutRegexps'
Attachment #8963389 - Flags: review?(bob)
Comment on attachment 8963389 [details] [diff] [review]
fix keyword argument to get_logcat()

r+. Sorry, should have caught that in the review.
Attachment #8963389 - Flags: review?(bob) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7b47c5196f0
Fix argument to get_logcat() in robocop and android mochitest harnesses; r=bc
https://hg.mozilla.org/mozilla-central/rev/a7b47c5196f0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: