Closed Bug 1449865 Opened 7 years ago Closed 6 years ago

Add a test to ensure object can be expanded while there's a text selection

Categories

(DevTools :: Console, enhancement, P2)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: julienw, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

STR: 1. Run this code in the console: var map = new Map(); for (var i = 0; i < 20; i++) { map.set('foo' + i, 'bar' + i); } map 2. select a word in the console, eg the "map" in the code above 3. try to expand the reps using the "arrow" icon => It's not possible. We first need to unselect by simply clicking elsewhere. Note that expanding clicking on "Map" seems to work.
Filed the issue on github. This should be resolved in the 0.22.0 reps bundle. It would be nice to make a mochitest here since in devtools-reps we rely on a shim to test the selection behavior.
No longer depends on: 1449165
Depends on: 1452566
Summary: Can't interact with reps' "expand" icon if some text is selected → Add a test to ensure object can be expanded while there's a text selection
Julien, I asked you for review on this since you reported the issue and that there isn't much console-specific code in the patch. But if you don't have enough time to look into this or don't feel confident to review this code, please tell me and I'll redirect to brian or honza
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: -- → P2
Comment on attachment 8979436 [details] Bug 1449865 - Add a test to ensure object can be expanded while there's a text selection; . https://reviewboard.mozilla.org/r/245620/#review251728 This looks good to me, but I assume you checked that the test actually fails before the reps change. Of course please make sure try is green for m-dt before landing.
Attachment #8979436 - Flags: review?(felash) → review+
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b0ac7491b94 Add a test to ensure object can be expanded while there's a text selection; r=julienw.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: