Closed
Bug 1450223
Opened 7 years ago
Closed 7 years ago
Make _buildSelectionMetadata not use getPage/ItemAnnotationNames
Categories
(Toolkit :: Places, enhancement, P2)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: mak, Assigned: standard8)
References
Details
(Keywords: perf, Whiteboard: [fxsearch])
Attachments
(1 file)
It is apparently possible to avoid calls to GetItemAnnotatioNames and GetPageAnnotationNames here, and additionally remove the latter.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → standard8
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8964518 [details]
Bug 1450223 - Remove unnecessary synchronous annotation lookups from the places context menu.
https://reviewboard.mozilla.org/r/233252/#review239350
woho, this is awesome!
::: browser/components/places/content/placesContextMenu.inc.xul:128
(Diff revision 1)
> <menuitem id="placesContext_reload"
> command="placesCmd_reload"
> label="&cmd.reloadLivebookmark.label;"
> accesskey="&cmd.reloadLivebookmark.accesskey;"
> closemenu="single"
> - selection="livemark/feedURI"/>
> + selection="isLivemark"/>
since we have livemarkChild, bookmark, folder, query... maybe this could just be "livemark"?
Attachment #8964518 -
Flags: review?(mak77) → review+
| Comment hidden (mozreview-request) |
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ffbab00395cb
Remove unnecessary synchronous annotation lookups from the places context menu. r=mak
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•