Closed
Bug 1450541
Opened 7 years ago
Closed 7 years ago
Values of non-enumerable symbol properties are not shown
Categories
(DevTools :: Console, defect)
Tracking
(firefox-esr52 unaffected, firefox59 wontfix, firefox60 verified, firefox61 verified)
VERIFIED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | wontfix |
firefox60 | --- | verified |
firefox61 | --- | verified |
People
(Reporter: Oriol, Assigned: Oriol)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
nchevobbe
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
Run this:
inspect(Object.defineProperty({}, Symbol(), {value: 1}))
Result:
▼ {…}
| Symbol(): undefined
| ▶ <prototype>: Object { … }
Expected:
▼ {…}
| Symbol(): 1
| ▶ <prototype>: Object { … }
This was regressed in https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7bda9cc7b79882ff5986a1e6192f64fe2aca1bb5&tochange=8b0058e2a4a8a123e09470b7ee975963be88a158 because the object inspector used another request protocol for symbols, but it's a server problem (https://searchfox.org/mozilla-central/rev/0e8eb01368600eb552dd558c83c64a3b6a0b89b8/devtools/server/actors/object.js#1215)
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8964181 [details]
Bug 1450541 - Show values of non-enumerable symbol properties in object inspector
https://reviewboard.mozilla.org/r/232928/#review238682
Nice and simple, with a test, that's perfect Oriol. Thanks a lot !
Attachment #8964181 -
Flags: review?(nchevobbe) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/efe04571107d
Show values of non-enumerable symbol properties in object inspector r=nchevobbe
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•7 years ago
|
Comment 6•7 years ago
|
||
Is this worth backport consideration or can it ride the 61 train to release?
Flags: needinfo?(oriol-bugzilla)
Flags: in-testsuite+
Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 8964181 [details]
Bug 1450541 - Show values of non-enumerable symbol properties in object inspector
Approval Request Comment
[Feature/Bug causing the regression]: it's noticeable since bug 1399460, but the problem existed since bug 1392614.
[User impact if declined]: the console will show undefined instead of the value of non-enumerable symbol properties when inspecting an object.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: I have manually verified it in Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: see comment 0
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: not risky
[Why is the change risky/not risky?]: trivial fix, it makes the symbol iterator stop passing onlyEnumerable=true parameter to _propertyDescriptor. Therefore non-enumerable descriptors are no longer ignored.
[String changes made/needed]: none
Flags: needinfo?(oriol-bugzilla)
Attachment #8964181 -
Flags: approval-mozilla-beta?
Comment 8•7 years ago
|
||
Comment on attachment 8964181 [details]
Bug 1450541 - Show values of non-enumerable symbol properties in object inspector
trivial devtools console bug fix, approved for 60.0b14
Attachment #8964181 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•7 years ago
|
||
bugherder uplift |
Comment 10•7 years ago
|
||
uplift |
Follow-up ESLint fix:
https://hg.mozilla.org/releases/mozilla-beta/rev/4c070065428f
Updated•7 years ago
|
Flags: qe-verify+
Comment 11•7 years ago
|
||
I managed to reproduce this issue on Firefox 59.0.2, under Windows 10x64.
The issue is no longer reproducible on Firefox 60.0b14, or on Firefox 61.0a1 (2018-04-20).
Tests were executed under Windows 10x64, Ubuntu 16.04x64, macOS 10.10.5.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•