Closed
Bug 1450684
Opened 7 years ago
Closed 2 years ago
[Windows] browser_style does not play well with themes
Categories
(WebExtensions :: General, defect, P3)
Tracking
(firefox59 affected, firefox60 affected, firefox61 affected)
RESOLVED
WONTFIX
People
(Reporter: emilpasca, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
image/png
|
Details |
**[Prerequisites]:**
- Have a Firefox profile with the latest "Firefox Notes" add-on version (3.1.0) installed (You can download it from here https://github.com/mozilla/notes/releases/tag/3.1.0 or https://testpilot.firefox.com/experiments/notes).
- Change the Windows theme option to "High Contrast # 1" or "High Contrast # 2".
**[Steps to reproduce]:**
1. Open the browser with the profile from prerequisites.
2. Observe the text in the "Notes" content area.
3. Click on the "Notes" sidebar switcher and observe the "Notes" text option and icon.
**[Expected result]:**
2. The text color in the "Notes" content area is white.
3. The "Notes" text option and icon color are green.
**[Actual result]:**
2. The text color in the "Notes" content area is dark grey(unreadable).
3. The "Notes" text option and icon color are white.
**[Additional Notes]:**
- Refs https://github.com/mozilla/notes/issues/417
- Attached a screen recording of the issue:
https://user-images.githubusercontent.com/20083658/33073434-9341166e-cecb-11e7-81a9-9ec28601a8a5.gif
Comment 1•7 years ago
|
||
P.S. This is not a "Notes" only issue. Another addon you can try is https://addons.mozilla.org/en-US/firefox/addon/tab-center-redux/ to reproduce the contrast issues. I'm suspecting this is true for any "webby" content loaded into the sidebar
Comment 2•7 years ago
|
||
This is caused by browser/components/extensions/extension.css setting the default background to transparent, and the default foreground colour to an opaque grey-ish colour. Because this is a browser stylesheet, it isn't subject to the high contrast restrictions and is applied, on top of the high contrast defaults, which means that the default background colour is black and the default foreground color is also black (ish). Add-on stylesheets themselves do get clobbered by HCM and so they can't fix this at all. The defaults need to be made high-contrast-friendly (probably best), or have high-contrast alternatives.
Shane, can you ensure this gets looked at and prioritized? Thanks!
Component: Disability Access → WebExtensions: Untriaged
Flags: needinfo?(mixedpuppy)
Product: Firefox → Toolkit
Comment 3•7 years ago
|
||
We triage bugs with no priority every Thursday.
I think we've a number of issues with browser_style that need to be addressed.
Flags: needinfo?(mixedpuppy)
Summary: [Windows] Notes UI and content are not rendered correctly in High Contrast mode → [Windows] browser_style does not play well with themes
Updated•7 years ago
|
Priority: -- → P2
Updated•6 years ago
|
Product: Toolkit → WebExtensions
Comment 4•6 years ago
|
||
Bulk move of bugs per https://bugzilla.mozilla.org/show_bug.cgi?id=1483958
Component: Untriaged → General
I have running Gnome with dark theme. Firefox is using the system colors. On some webpages the contrast is very bad. See wikipedia example https://de.wikipedia.org/wiki/Normalverteilung
Updated•5 years ago
|
Priority: P2 → P3
Updated•2 years ago
|
Severity: normal → S3
Comment 6•2 years ago
|
||
Closing bug because support for browser_style
feature is going to be removed (at least in MV3), see bug 1827910.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•