Closed
Bug 1450757
Opened 7 years ago
Closed 7 years ago
Remove XUL style overlays in Thunderbird
Categories
(Thunderbird :: General, enhancement)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 61.0
People
(Reporter: bdahl, Assigned: Paenglab)
Details
Attachments
(1 file)
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
Over in bug 1450753, I'm planning to remove xul style overlays. Looks like there's two uses in thunderbird:
https://searchfox.org/comm-central/search?q=style&case=false®exp=false&path=*.manifest
Comment 1•7 years ago
|
||
There are a few more actually: https://searchfox.org/comm-central/search?q=style&path=jar.mn
For Thunderbird add-ons this will be fixed by bug 1448808, but we'll need to load manually for Thunderbird proper.
So the replacement is to load the css files directly in the xul files where possible, or insert them via JS, e.g. like contentStylesheet = aDocument.createProcessingInstruction("xml-stylesheet",
'href="chrome://messenger/*.css" type="text/css"');
document.insertBefore(contentStylesheet, document.documentElement);
Comment 3•7 years ago
|
||
Richard, can you take a look at these, please.
https://searchfox.org/comm-central/search?q=%25+style&case=false®exp=false&path=jar.mn
ignoring calendar/ and dead im/ only yields 8 of these:
% style chrome://messenger/content/customizeToolbar.xul chrome://messenger/...
That's assuming bug 1450218 has landed (which it will RSN(TM)).
Summary: Remove XUL style overlays → Remove XUL style overlays in Thunderbird
Assignee | ||
Comment 4•7 years ago
|
||
This removes the style overlays and adds them directly to customizeToolbar.xul.
Comment 5•7 years ago
|
||
Comment on attachment 8972687 [details] [diff] [review]
styleOverlay.patch
Looks straight forward and seems to work. Thanks.
Attachment #8972687 -
Flags: review?(jorgk) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3a08130870ef
Remove XUL style overlays in Thunderbird. r=jorgk
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 61.0
You need to log in
before you can comment on or make changes to this bug.
Description
•