Closed
Bug 1450982
Opened 7 years ago
Closed 7 years ago
Remove old-event-emitter usage from devtools/shared
Categories
(DevTools :: General, enhancement)
DevTools
General
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8964779 [details]
Bug 1450982 - Remove old-event-emitter usage from devtools/shared; .
https://reviewboard.mozilla.org/r/233510/#review239366
Thanks for working this! :)
::: devtools/shared/apps/Devices.jsm:8
(Diff revision 1)
> * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>
> "use strict";
>
> const { require } = ChromeUtils.import("resource://devtools/shared/Loader.jsm", {});
> -const EventEmitter = require("devtools/shared/old-event-emitter");
> +const EventEmitter = require("devtools/shared/event-emitter");
These events are also listened from ADB Helper:
https://github.com/mozilla/adbhelper
However, a quick search suggests that the listeners don't use arguments, so it should be okay.
Attachment #8964779 -
Flags: review?(jryans) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Thanks for the review and the pointer to adbhelper. I double checked there and it does seem that we should be alright.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc75aa07f46f
Remove old-event-emitter usage from devtools/shared; r=jryans.
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•