Closed
Bug 1451102
Opened 7 years ago
Closed 7 years ago
Get layout/reftests/bugs/614272-1.svg passing with blob invalidation
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: Gankra)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
No description provided.
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → a.beingessner
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8965852 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Comment 2•7 years ago
|
||
Tweaked to go back to scaling the DT
Attachment #8965852 -
Attachment is obsolete: true
Attachment #8965852 -
Flags: review?(jmuizelaar)
Attachment #8965857 -
Flags: review?(jmuizelaar)
|
|
Reporter | |
Updated•7 years ago
|
Attachment #8965857 -
Flags: review?(jmuizelaar) → review+
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 4•7 years ago
|
||
Comment on attachment 8965857 [details] [diff] [review]
Bug 1451102 - roundout blobimage bounds and use that result consistently.
Whoops this needed to be squashed with its predecessor!
Attachment #8965857 -
Attachment is obsolete: true
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8965923 [details]
Bug 1451102 - roundout blobimage bounds and use that result consistently.
https://reviewboard.mozilla.org/r/234732/#review240402
Attachment #8965923 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 7•7 years ago
|
||
|
|
Reporter | |
Comment 8•7 years ago
|
||
It looks like this makes some things better and some things worse. There's a bunch of new failures in R6 that all look a similar cause.
It also looks like a bunch of tests might have been regressed by bug 1451761
|
|
Assignee | |
Comment 9•7 years ago
|
||
As far as I can tell, the only regression is this huge pile of smil tests which are now losing pixels on the bottom/right: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/YOaz9iU-Q-ygA7xa3dLaJA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Just now taking a look into it, but if I had to guess our division trick is inadequate.
Sadly, I haven't been able to reproduce this regression locally.
|
|
Assignee | |
Comment 10•7 years ago
|
||
Oh no wait, the non-gradient test cases here are also regressions: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/BME9tV6cTomlCv2HQqSTIA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
looks like some text is disappearing.
|
|
Assignee | |
Comment 11•7 years ago
|
||
After some investigation it appears all the regressions we're seeing here are intermittents caused by the bugs in Jeff's dirtyrect stuff. So we should be able to just land this now, and the issues will go away when that gets fixed.
Keywords: checkin-needed
|
||
Comment 12•7 years ago
|
||
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3c654a2185f
roundout blobimage bounds and use that result consistently. r=jrmuizel
Keywords: checkin-needed
|
||
Comment 13•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•