readability-static-accessed-through-instance is 6.0 only and bugprone-forward-declaration-namespace was called misc-forward-declaration-namespace in 5.0 (renamed in 6.0) http://releases.llvm.org/6.0.0/tools/clang/tools/extra/docs/ReleaseNotes.html

Comment on attachment 8964924 [details] Bug 1451331 - Fix the name of the checkers as we are using clang-tidy 5.0 https://reviewboard.mozilla.org/r/233650/#review239258 Code analysis found 2 defects in this patch: - 2 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: tools/clang-tidy/config.yaml:9 (Diff revision 1) > # in order to have consistency across the used checkers. > # All the clang checks used by the static-analysis tools. > clang_checkers: > - name: -* > publish: !!bool no > - - name: bugprone-forward-declaration-namespace > +# Name with clang tidy 6.0. We are currently using 5.0 Warning: Comment not indented like content [yamllint: comments-indentation] ::: tools/clang-tidy/config.yaml:80 (Diff revision 1) > publish: !!bool no > - name: readability-redundant-string-cstr > publish: !!bool yes > - name: readability-redundant-string-init > publish: !!bool yes > - - name: readability-static-accessed-through-instance > +# Only available from clang tidy 6.0. We are currently using 5.0 Warning: Comment not indented like content [yamllint: comments-indentation]

Comment on attachment 8964924 [details] Bug 1451331 - Fix the name of the checkers as we are using clang-tidy 5.0 https://reviewboard.mozilla.org/r/233650/#review239546

Comment on attachment 8964924 [details] Bug 1451331 - Fix the name of the checkers as we are using clang-tidy 5.0 https://reviewboard.mozilla.org/r/233650/#review239548

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b6457ac324bf Fix the name of the checkers as we are using clang-tidy 5.0 r=andi