Closed
Bug 145136
Opened 23 years ago
Closed 22 years ago
build failure: ENOTSUP undeclared
Categories
(Directory :: LDAP C SDK, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.2
People
(Reporter: netscape, Assigned: netscape)
References
Details
(Whiteboard: [fixed on ldap trunk, csdk50client branch])
Attachments
(2 files)
(deleted),
patch
|
dmosedale
:
review+
dbaron
:
approval+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dmosedale
:
review+
dbaron
:
approval+
|
Details | Diff | Splinter Review |
I'm hitting this error on the new OpenBSD 3.0 tinderbox:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1021593060.29830.gz&fulltext=1
gcc -o ldappr-error.o -c -ansi -Wall -pthread -O -fPIC -UDEBUG
-DMOZILLA_CLIENT=1 -DNDEBUG=1 -DXP_UNIX=1 -DOPENBSD=1 -DHAVE_BSD_FLOCK=1
-DHAVE_LCHOWN=1 -DHAVE_STRERROR=1 -D_THREAD_SAFE=1 -DFORCE_PR_LOG
-D_PR_PTHREADS -UHAVE_CVAR_BUILT_ON_SEM -DUSE_WAITPID -DNEEDPROTOS -DNET_SSL
-DNO_LIBLCACHE -DLDAP_REFERRALS -DNS_DOMESTIC
-I/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/obj-i386-pc-openbsd3.0/dist/public/ldap
-I/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/include
-I/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/obj-i386-pc-openbsd3.0/dist/./include
-I/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/obj-i386-pc-openbsd3.0/dist/include/nspr
/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c
/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c:199:
`ENOTSUP' undeclared here (not in a function)
/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c:199:
initializer element is not constant
/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c:199:
(near initialization for `prldap_errormap[8].erm_system')
/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c:229:
`EOVERFLOW' undeclared here (not in a function)
/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c:229:
initializer element is not constant
/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c:229:
(near initialization for `prldap_errormap[38].erm_system')
/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c:233:
`EDEADLOCK' undeclared here (not in a function)
/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c:233:
initializer element is not constant
/builds/tinderbox/SeaMonkey/OpenBSD_3.0_Depend/mozilla/directory/c-sdk/ldap/libraries/libprldap/ldappr-error.c:233:
(near initialization for `prldap_errormap[42].erm_system')
gmake[7]: *** [ldappr-error.o] Error 1
Assignee | ||
Comment 1•23 years ago
|
||
-> dmose
Assignee | ||
Comment 2•23 years ago
|
||
Comment 3•23 years ago
|
||
Comment on attachment 83986 [details] [diff] [review]
Add || defined(OPENBSD) as necessary
r=dmose
Attachment #83986 -
Flags: review+
Assignee | ||
Comment 4•23 years ago
|
||
This patch has been checked into the ldap trunk and the csdk 50 client branch.
Blocks: 138348
Whiteboard: [fixed on ldap trunk, csdk50client branch]
Comment 5•23 years ago
|
||
This also affects NetBSD. They have a patch available at
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/www/mozilla/patches/patch-bj.
why not do #ifndef ENOTSUP instead of checking for os's known not to have the
def?
Comment 7•23 years ago
|
||
David: the NetBSD build problems are already covered by a fix in another bug
(bug 135027).
Timeless: a good idea for a future cleanup of this file.
Assignee | ||
Comment 8•23 years ago
|
||
Bah. The previous patch got it to compile but once we got something running
that used ldap, we have missing symbol errors. OpenBSD needs the same ifdefs
that pretty much every platform needs so that symbols are resolved at link
time.
Updated•23 years ago
|
Attachment #83986 -
Flags: approval+
Updated•23 years ago
|
Attachment #84975 -
Flags: approval+
Comment 9•23 years ago
|
||
Please land this on the 1.0.1 branch. Once there, replace the
"mozilla1.0.1+" keyword with the "fixed1.0.1" keyword.
(I'm assuming that both of the patches have already been checked into
the trunk. It's not entirely clear.)
Keywords: mozilla1.0.1+
Assignee | ||
Comment 11•23 years ago
|
||
Removing nominations. The second patch hasn't even landed on the trunk yet and
Moz still has issues running on OpenBSD.
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla1.1 → mozilla1.2
Assignee | ||
Comment 12•23 years ago
|
||
*** Bug 160428 has been marked as a duplicate of this bug. ***
Comment 13•22 years ago
|
||
Comment on attachment 84975 [details] [diff] [review]
Fix missing runtime symbols error
r=dmose
Attachment #84975 -
Flags: review+
Assignee | ||
Comment 14•22 years ago
|
||
Patch has been checked into the ldap trunk & the csdk50client branch.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•