Closed Bug 1451526 Opened 7 years ago Closed 6 years ago

Convert mozscreenshots to a webextension

Categories

(Testing :: mozscreenshots, enhancement, P3)

Version 3
enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: aswan, Assigned: aswan)

References

Details

Attachments

(1 file)

No description provided.
Priority: -- → P3
Depends on: 1411641
No longer depends on: 1411641
Assignee: nobody → aswan
Dup of bug 1422437 ?
Flags: needinfo?(aswan)
No, mozscreenshots (browser/tools/mozscreenshots) is used in automation, it is different from the user-facing "Firefox Screenshots" which is tracked in the bug you referenced.
Flags: needinfo?(aswan)
Some notes on the attached patch: Try run (linux only): https://treeherder.mozilla.org/#/jobs?repo=try&revision=6074032793d08954ad15b888fbcced4ca7767c43 Screenshots comparison page from try run: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=0d4e73bc2cd705d7a021c75a0e8aeb174ab4db59&newProject=try&newRev=951897fd2313dc374b606564cb65b28391338c98 One quirk with the port is that I converted all the extension urls from chrome: to resource: This was mostly fine except for the devtools tests which apparently relied on this code: https://searchfox.org/mozilla-central/rev/a11c128b90ea85d7bb68f00c5de52c0794e0b215/browser/tools/mozscreenshots/mozscreenshots/extension/TestRunner.jsm#211 When navigating from a chrome: url to a data: url, this was a remoteness change which tore down the old browser and closed devtools gracefully. When the page being tested switched to resource:, that navigation just became a regular navigation that left devtools open. This led to a race during shutdown that caused test hangs. I addressed this by having browser_devtools.js explicitly clean up which isn't the tidiest solution but it was expedient...
Even new comparison: https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=a0aa8da7e8554476a3c14f53fc0a39664abc2ebc&newProject=try&newRev=a2ab8658c809173960961d1ba3d897abcebbb456 There are a bunch of differences, many of them one-time changes related to pages used in the tests changing urls (from chrome: to resource:). The rest appear to be inconsistencies that are not currently flagged as such in the comparison backend.
Pushed by aswan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e8f0ddeec2f1 Convert mozscreenshots to a webextension r=MattN
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: