Closed
Bug 1451713
Opened 7 years ago
Closed 7 years ago
Use SVG icon for verification failed in update UI
Categories
(Toolkit :: Themes, enhancement)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: ntim, Assigned: manishkk)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Replacing:
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/mozapps/update/updates.css#109
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/mozapps/update/updates.css#133
with:
-moz-context-properties: fill;
fill: currentColor;
list-style-image: url(chrome://global/skin/icons/warning.svg);
allows removing 2 PNG icons:
toolkit/themes/windows/global/icons/information-16.png
toolkit/themes/osx/global/icons/notfound.png
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → 1991manish.kumar
|
Reporter | |
Comment 2•7 years ago
|
||
Comment on attachment 8965296 [details] [diff] [review]
Patch_Bug1451713
Review of attachment 8965296 [details] [diff] [review]:
-----------------------------------------------------------------
You also need to remove those:
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/jar.mn#49
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/jar.mn#66
Attachment #8965296 -
Flags: review?(ntim.bugs)
|
|
Reporter | |
Comment 3•7 years ago
|
||
Comment on attachment 8965296 [details] [diff] [review]
Patch_Bug1451713
Review of attachment 8965296 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/themes/windows/mozapps/update/updates.css
@@ +105,4 @@
> }
>
> #verificationFailedIcon {
> + margin-left: 5px;
This indentation should remain unchanged.
|
|
Assignee | |
Comment 4•7 years ago
|
||
Please review
Attachment #8965296 -
Attachment is obsolete: true
Attachment #8965311 -
Flags: review?(ntim.bugs)
|
|
Reporter | |
Updated•7 years ago
|
Attachment #8965311 -
Flags: review?(ntim.bugs) → review?(dao+bmo)
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8965311 [details] [diff] [review]
PatchV2_Bug1451713
>--- a/toolkit/themes/osx/mozapps/update/updates.css
>+++ b/toolkit/themes/osx/mozapps/update/updates.css
>@@ -130,7 +130,10 @@ wizardpage {
>
> #verificationFailedIcon {
> margin-left: 5px;
>- list-style-image: url("chrome://global/skin/icons/notfound.png");
>+ -moz-context-properties: fill;
>+ fill: currentColor;
>+ list-style-image: url(chrome://global/skin/icons/warning.svg);
>+
Please remove the empty line.
>--- a/toolkit/themes/windows/mozapps/update/updates.css
>+++ b/toolkit/themes/windows/mozapps/update/updates.css
>@@ -106,7 +106,10 @@ wizardpage {
>
> #verificationFailedIcon {
> margin-left: 5px;
>- list-style-image: url("chrome://global/skin/icons/information-16.png");
>+ -moz-context-properties: fill;
>+ fill: currentColor;
>+ list-style-image: url(chrome://global/skin/icons/warning.svg);
>+
ditto
Thanks!
Attachment #8965311 -
Flags: review?(dao+bmo) → review+
|
|
Assignee | |
Comment 6•7 years ago
|
||
:ntim
when I am applying this patch on my repo.
https://pastebin.mozilla.org/9082341
getting this error. while I roolback and revert all changes.
Flags: needinfo?(ntim.bugs)
|
|
Reporter | |
Comment 7•7 years ago
|
||
(In reply to Manish Kumar from comment #6)
> :ntim
>
> when I am applying this patch on my repo.
> https://pastebin.mozilla.org/9082341
This is because you already have the patch applied.
Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/878f06687e5a
Use SVG icon for verification failed in update UI. r=dao
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•