Mozprofile's AddonManager has a bunch of features that don't appear to be used anywhere. This includes installing addons from manifests, from urls and from AMO. I'd like to simplify it down to the bare minimum required to get addons installed given a local file path, possibly to the point where it is just an instance method on the Profile class. I'm attempting to standardize an API for managing profiles that extend across Firefox, Chrome and potentially other browsers in the future. Having all this extra cruft will make this harder to accomplish. CC'ed a bunch of people, please let me know if you are aware of anything using these features (I couldn't find any via dxr).

This sounds fine, I always thought that part of mozprofile was rather overengineered. FWIW the mozregression code that installs addons is around here. It doesn't use any of the fancier features that you mention: https://github.com/mozilla/mozregression/blob/5b468a469280978bac6401db5d772e5973e46135/mozregression/launchers.py#L154

I'm purposefully not version bumping just yet as I'll be working on some other major possibly breaking changes shortly after this.

Try looking good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ea14430c81c10c9091097137618ed95562292e0

Comment on attachment 8965472 [details] Bug 1451733 - [mozprofile] Remove ability to install from a manifest https://reviewboard.mozilla.org/r/234230/#review240134 this looks like a clean extraction

Comment on attachment 8965473 [details] Bug 1451733 - [mozprofile] Remove ability to download addons from AddonManager https://reviewboard.mozilla.org/r/234232/#review240138

Comment on attachment 8965474 [details] Bug 1451733 - [mozprofile] Clean up the public facing addons API a bit https://reviewboard.mozilla.org/r/234234/#review240142 excellent

Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/796b0795dc5a [mozprofile] Remove ability to install from a manifest r=jmaher https://hg.mozilla.org/integration/autoland/rev/538664e0c822 [mozprofile] Remove ability to download addons from AddonManager r=jmaher https://hg.mozilla.org/integration/autoland/rev/5a16ea729deb [mozprofile] Clean up the public facing addons API a bit r=jmaher

https://hg.mozilla.org/mozilla-central/rev/796b0795dc5a https://hg.mozilla.org/mozilla-central/rev/538664e0c822 https://hg.mozilla.org/mozilla-central/rev/5a16ea729deb