Mike Kaply [:mkaply] Reporter
	Description • 6 years ago

Currently in preferences, we have a checkbox that says:

"Remember logins and passwords for websites"

But that's not actually what it does. Checking that box causes Firefox to offer to save logins and passwords, and when you uncheck it, it doesn't offer.

It should be renamed to convey what it actually does. Maybe:

"Offer to save logins and passwords for websites"

As it exists today, it implies we remember passwords and logins without user intervention.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 1 • 6 years ago

Meridel, what do you think about this change?

	mheubusch
	Comment 2 • 6 years ago

Hi - thanks for pointing this out - let's use Ask to be consistent with other parts of preferences:

Ask to save logins and passwords for websites

	Jared Wein [:jaws] (please needinfo? me)
	Comment 3 • 6 years ago

To fix this bug, you'll need to update the string at
https://searchfox.org/mozilla-central/rev/b55e1a1cbcaee34878e133fbac20c4c2af6e11b5/browser/locales/en-US/browser/preferences/preferences.ftl#589

and also change the key from `forms-remember-logins` to `forms-ask-to-save-logins`.

The new key name will need to be updated at https://searchfox.org/mozilla-central/rev/b55e1a1cbcaee34878e133fbac20c4c2af6e11b5/browser/components/preferences/in-content/privacy.xul#26

zibi, does https://searchfox.org/mozilla-central/rev/b55e1a1cbcaee34878e133fbac20c4c2af6e11b5/python/l10n/fluent_migrations/bug_1446180_preferences_privacy.py#49 need to get updated too?

	Zibi Braniecki [:zbraniecki][:gandalf]
	Comment 4 • 6 years ago

Flod is maintaining the migrations, redirecting the question to him.

	Francesco Lodolo [:flod]
	Comment 5 • 6 years ago

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> zibi, does
> https://searchfox.org/mozilla-central/rev/
> b55e1a1cbcaee34878e133fbac20c4c2af6e11b5/python/l10n/fluent_migrations/
> bug_1446180_preferences_privacy.py#49 need to get updated too?

No need to touch the migration.

Depending on when this bug will be fixed, we might actually need to keep around the old string. If that's not the case, I'll clean up the migration as soon as needed.

	Phabricator Automation
	Comment 6 • 6 years ago

Rename 'Remember logins and passwords for websites' to 'Ask to save logins and passwords for website'

	Phabricator Automation
	Comment 7 • 6 years ago

Comment on attachment 8967466 [details]
Bug 1451864 - Rename 'Remember logins and passwords for websites' to 'Ask to save logins and passwords for website' r=jaws

Francesco Lodolo [:flod] has approved the revision.

https://phabricator.services.mozilla.com/D926

	Phabricator Automation
	Comment 8 • 6 years ago

Comment on attachment 8967466 [details]
Bug 1451864 - Rename 'Remember logins and passwords for websites' to 'Ask to save logins and passwords for website' r=jaws

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

https://phabricator.services.mozilla.com/D926

	Pulsebot
	Comment 9 • 6 years ago

Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e48058b5e3cf
Rename 'Remember logins and passwords for websites' to 'Ask to save logins and passwords for website' r=jaws,flod

	Arthur Iakab [arthur_iakab]
	Comment 10 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e48058b5e3cf