Closed
Bug 1452136
Opened 7 years ago
Closed 6 years ago
Audit *Unsafe MacroAssembler methods
Categories
(Core :: JavaScript Engine: JIT, enhancement, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox60 | --- | wontfix |
firefox61 | - | fix-optional |
People
(Reporter: jandem, Assigned: nbp)
References
(Blocks 1 open bug)
Details
We mitigated most object type checks, but there are a few callers of loadObjGroupUnsafe (and some other *Unsafe methods) that we have to audit still.
Assignee | ||
Updated•7 years ago
|
status-firefox61:
--- → affected
Priority: -- → P1
Assignee | ||
Updated•6 years ago
|
tracking-firefox61:
--- → ?
Assignee | ||
Updated•6 years ago
|
status-firefox60:
--- → fix-optional
Reporter | ||
Comment 2•6 years ago
|
||
I was asked to file it but I'm not working on this.
Flags: needinfo?(jdemooij)
Comment 3•6 years ago
|
||
Needs an assignee or a reduction in priority.
Flags: needinfo?(nicolas.b.pierron)
Updated•6 years ago
|
Flags: needinfo?(jorendorff)
Comment 4•6 years ago
|
||
Reduced priority. Jan, I think this is appropriate. If not, please find someone to take the bug, or set tracking? for the next release.
Flags: needinfo?(nicolas.b.pierron)
Flags: needinfo?(jorendorff)
Flags: needinfo?(jdemooij)
Priority: P1 → P2
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(jdemooij) → needinfo?(sdetar)
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
I will look at this bug soon.
Flags: needinfo?(sdetar) → needinfo?(nicolas.b.pierron)
Priority: P2 → P1
Assignee | ||
Comment 6•6 years ago
|
||
To be precise *Unsafe in this bug title corresponds to callers of:
- branchTestObjShapeUnsafe
- branchTestObjGroupUnsafe
- loadObjGroupUnsafe
- loadObjClassUnsafe
I will start auditing these call sites.
Assignee: nobody → nicolas.b.pierron
Status: NEW → ASSIGNED
Flags: needinfo?(nicolas.b.pierron)
Assignee | ||
Updated•6 years ago
|
Attachment #8979217 -
Flags: feedback?(jdemooij)
Reporter | ||
Updated•6 years ago
|
Attachment #8979217 -
Flags: feedback?(jdemooij) → feedback+
Assignee | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•