Closed
Bug 1452674
Opened 7 years ago
Closed 7 years ago
Firefox Update door-hanger highlight state in Dark theme needs updating
Categories
(Firefox :: Theme, defect, P5)
Tracking
()
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: amylee, Assigned: vivek3zero, Mentored)
References
Details
Attachments
(2 files)
Door-hanger Spec.jpg
Hi,
The door-hanger highlight state for Firefox updates in Dark theme needs to be updated. See spec for details. This also coincides with updates to the Dark theme door-hanger colour in Bug 1451947.
|
||
Updated•7 years ago
|
Blocks: dark-theme-darkening
Priority: -- → P5
|
||
Updated•7 years ago
|
Assignee: nobody → vivek3zero
Mentor: jaws, mconley, ntim.bugs
|
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 2•7 years ago
|
||
These styles are currently set here,
https://searchfox.org/mozilla-central/rev/9f3da81290054c5b8955bb67ff98cae66676f745/browser/themes/shared/customizableui/panelUI.inc.css#755-766
You'll need to add another section below that uses the `:root[lwt-popup-brighttext] .panel-banner-item` selector.
| Comment hidden (mozreview-request) |
Attachment #8967885 -
Flags: review?(ntim.bugs)
Attachment #8967885 -
Flags: review?(jaws)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8967885 [details]
Bug 1452674 - Firefox Update door-hanger highlight state in Dark theme needs updating
https://reviewboard.mozilla.org/r/236572/#review242464
Tested and looks good on my machine, thanks!
Attachment #8967885 -
Flags: review?(ntim.bugs) → review+
|
|
||
Updated•7 years ago
|
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8967885 [details]
Bug 1452674 - Firefox Update door-hanger highlight state in Dark theme needs updating
https://reviewboard.mozilla.org/r/236572/#review242552
::: browser/themes/shared/customizableui/panelUI.inc.css:777
(Diff revision 3)
> +
> +:root[lwt-popup-brighttext] .panel-banner-item:not([disabled]):hover{
> + background-color: rgba(48, 230, 11, 0.15);
> +}
> +
> +:root[lwt-popup-brighttext] .panel-banner-item:not([disabled]):active{
nit: space before {
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2f017455c09
Firefox Update door-hanger highlight state in Dark theme needs updating. r=ntim,jaws
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8967885 [details]
Bug 1452674 - Firefox Update door-hanger highlight state in Dark theme needs updating
https://reviewboard.mozilla.org/r/236572/#review242798
I've fixed the spacing issues and pushed this to inbound for you.
Attachment #8967885 -
Flags: review?(jaws) → review+
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•