- there were too many commits on master to add everything to 33, so this is just a partial list - there are some firebug additions (that will be gone in 34)

I need to backport commit 4f62b4b0dd71def8e539ea85a4047899c8775a79 Author: Gregory Mierzwinski <gmierz2@outlook.com> Date: Fri Apr 6 13:38:44 2018 -0400 Bug 1448523 - Disable browser_dbg-babel-preview.js on windows10-64-ccov. r=jmaher This patch disables devtools/client/debugger/new/test/mochitest/browser_dbg-babel-preview.js when run on windows10-64-ccov. MozReview-Commit-ID: HWoAsO0Q8tY

this flips moz-scopes, but that likely will need to be reverted bc of talos

Comment on attachment 8966352 [details] [diff] [review] rel-33.patch Review of attachment 8966352 [details] [diff] [review]: ----------------------------------------------------------------- Try is orange with leaks on several debugger tests. Still fails DAMP: ./mach talos-test --activeTests damp --subtest custom.debugger --cycles 1 --tppagecycles 1 + missing sync from mc ::: devtools/client/debugger/new/test/mochitest/browser.ini @@ +136,5 @@ > [browser_dbg-async-stepping.js] > [browser_dbg-babel-breakpoint-console.js] > [browser_dbg-babel-scopes.js] > [browser_dbg-babel-stepping.js] > [browser_dbg-babel-preview.js] Missing sync from Bug 1448523 (on a sidenote the test should not have been disabled, it should require longer timeout)

This should all be fixed. I disabled map-scopes in talos while we work on the features performance. The talos test is the evil case for original scopes. We can re-enable it after we land some performance fixes to the feature. When we do, we should be careful that we don't swamp the performance of stepping.

Comment on attachment 8966598 [details] [diff] [review] rel-33-2.patch Review of attachment 8966598 [details] [diff] [review]: ----------------------------------------------------------------- r+ with comments addressed and green try. ::: devtools/client/debugger/new/test/mochitest/browser.ini @@ +135,5 @@ > [browser_dbg-asm.js] > [browser_dbg-async-stepping.js] > [browser_dbg-babel-breakpoint-console.js] > [browser_dbg-babel-scopes.js] > +skip-if = (os == "win" && ccov) # Bug 1448523 Wrong test, this should be on browser_dbg-babel-preview.js ::: testing/talos/talos/tests/devtools/addon/content/tests/head.js @@ +40,5 @@ > } > exports.runTest = runTest; > > exports.testSetup = function(url) { > + Services.prefs.setBoolPref("devtools.debugger.features.map-scopes", false); Can we do that in the custom debugger test rather than here? With a comment explaining why this is needed. /testing/talos/talos/tests/devtools/addon/content/tests/debugger/custom.js @@ +45,5 @@ > return damp.testSetup(url); > }; > > exports.testTeardown = function() { > + Services.prefs.clearBoolPref("devtools.debugger.features.map-scopes"); clearBoolPref does not exist, you probably want clearUserPref. (and let's move this to the debugger test as well)

Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/417fa1dd6bb9 Update Debugger Frontend v33. r=jdescottes

# 33-1 https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=a138a829af738001250e44f256c617afbbc03016 https://github.com/devtools-html/debugger.html/compare/master...jasonLaster:release-33-1 # 33-2 https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=21926aa08c8c9f683e435329de522bb107c9553a https://github.com/devtools-html/debugger.html/compare/master...jasonLaster:release-33-2 # 33-b https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=fab24b4ef586a661a0157aaeb8defc37089ac9ce https://github.com/devtools-html/debugger.html/compare/master...jasonLaster:release-33-b

baseline - https://github.com/devtools-html/debugger.html/compare/release-32...jasonLaster:release-33-b https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=fab24b4ef586a661a0157aaeb8defc37089ac9ce half way - https://github.com/devtools-html/debugger.html/compare/release-32...jasonLaster:release-33-2 https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=21926aa08c8c9f683e435329de522bb107c9553a full run - https://github.com/devtools-html/debugger.html/compare/release-32...jasonLaster:release-33-1 https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=a138a829af738001250e44f256c617afbbc03016

v32 baseline - https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=dbd79f1673b269ad5028ea8586c10ad79d50a7c4

v33 run - https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=31ec7fa875dfc35885247492713f5c165580a6d8

some pause info: http://firefox-dev.tools/performance-dashboard/tools/debugger.html?days=60&filterstddev=true we're looking at the pause regression that appeared on 4/11 https://shipusercontent.com/9e490bfdebf5de866eb5b4015d65fc23/Screen%20Shot%202018-05-14%20at%209.42.57%20AM.png here is a regression sheet https://docs.google.com/spreadsheets/d/1OexQ2TaH0ze4ZXUjNMucpsk8TnjzPLAHdRJrSvprYr4/edit#gid=0

v33-1 run https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=7b68c216753425f108741f237c20acbfe176fe8b cut at db286a4 and excludes syntax highlighting breakpoints

v33-2 run https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9255b99bd7eb617f8e7a7e3fead74ed45d173ef https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=e9255b99bd7eb617f8e7a7e3fead74ed45d173ef cut at bce70803 and excludes `Switched getExtraProps` but keeps the preview work w/ generate

33 sans syntax highlighting https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=db585689645ba043c8778bb1a1ce8223327d464d

new 33-sans run https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=1ef8caf406bc83db65a68a585489334e8ed21f6a

last run was sans-sans yikes! new one https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=96f2e40ba7516f7bc4732cbb1284157483ea57db