Closed
Bug 1452881
Opened 7 years ago
Closed 7 years ago
Remove usechromesheets support.
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Nobody uses this attribute, and I want to simplify the loader constructors.
|
Assignee | |
Comment 1•7 years ago
|
||
Hey Richard, PSA, this is only used in one place in comm-central, which is a theme:
https://searchfox.org/comm-central/rev/fae4b6658306aabf5b4193947ea49fbf6fb04c42/suite/themes/modern/communicator/sidebar/sidebar.css#89
Would you want me to hold off on it because of that?
Flags: needinfo?(richard.marti)
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
I'm working only on TB and not SM. But SM is broken ATM, so I think they don't hold you off.
Let's better ask SM people. Frank-Rainer and Ian can you reply to Emilio's comment 1?
Flags: needinfo?(richard.marti)
Flags: needinfo?(iann_bugzilla)
Flags: needinfo?(frgrahl)
|
||
Comment 4•7 years ago
|
||
Sidebar has been broken by a rdf removal change and Modern with a change which removed full theme support. We will fix it later for SeaMonkey. No need to block or change it currently.
Flags: needinfo?(iann_bugzilla)
Flags: needinfo?(frgrahl)
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8966499 [details]
Bug 1452881: Remove usechromesheets support.
https://reviewboard.mozilla.org/r/235214/#review241228
Looks good. I don't know when the last time usechromesheets="" would have been used in mozilla-central, but my "git log -S" has been running for a while and hasn't come up with anything...
Attachment #8966499 -
Flags: review?(cam) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/06c4c125d022
Remove usechromesheets support. r=heycam
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•