Closed
Bug 1452920
Opened 7 years ago
Closed 5 years ago
Convert WebConsoleActor to protocol.js
Categories
(DevTools :: General, enhancement, P2)
DevTools
General
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: yulia, Assigned: yulia)
References
(Depends on 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
Webconsole is a dependancy for the conversion of AddonActor
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ystartsev
Depends on: 1449162
Updated•7 years ago
|
Severity: normal → enhancement
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
Note: AddonConsole inherits from this actor, there will be some clean up there once this is updated
Updated•6 years ago
|
Product: Firefox → DevTools
Assignee | ||
Comment 2•6 years ago
|
||
We also need to address refactoring evaluateJSAsync, as it is currently a synchronous function. Several older actors are relying on it so this needs to be done with care. New actors can return promises, but evaluateJSAsync breaks if it is turned into one.
what needs to be done once protocol.js is introduced is that we modernize this function, and make sure that the tests are passing. here is a try run with the failing tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6d34f4f03a85b601745d641625d29a8e0cd316a
Assignee | ||
Comment 3•6 years ago
|
||
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5cba74a67e19
Convert WebConsoleActor to protocoljs Actor. r=nchevobbe,yulia
Comment 6•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Updated•5 years ago
|
Updated•5 years ago
|
Attachment #9059252 -
Attachment is obsolete: true
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a2f71c2dfd2
Clean up WebConsoleActor events and responses. r=nchevobbe
Comment 9•5 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•