Closed
Bug 1452926
Opened 7 years ago
Closed 7 years ago
Add back easing to the videocontrol control animation
Categories
(Toolkit :: Video/Audio Controls, enhancement)
Toolkit
Video/Audio Controls
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(1 file)
I've just realized from some other comments - there was no timing function specified for the transition, so it used the default, which was "ease". AIUI the web animation stuff will just do a linear animation by default. We should add back easing.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
Of course, it turns out that it's a bit tricky to add it to the status overlay animation because of how the delay is encoded. Once we ship web animations everywhere, the easing will work and so would switching to a proper 'delay' property, which would then make it sensible to add easing there, too. Right now, the easing property should work on nightly+devedition and be ignored on beta/release because support is (at least according to MDN) behind the pref.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8966578 [details]
Bug 1452926 - add easing back to videocontrol control animations,
https://reviewboard.mozilla.org/r/235308/#review241202
According to https://www.w3.org/TR/css-transitions-1/#transition-timing-function-property and https://www.w3.org/TR/web-animations-1/#timing-functions, yes we need to set timing function to 'ease' explicitly here. Thank you for catching that!
Attachment #8966578 -
Flags: review?(timdream) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d082bbf8687a
add easing back to videocontrol control animations, r=timdream
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•