Closed Bug 1453066 Opened 7 years ago Closed 7 years ago

Update Debugger Frontend v34

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

Assignee: nobody → jlaster
Priority: -- → P3
Attached patch rel-34.patch (deleted) — Splinter Review
Attachment #8966684 - Flags: review?(jdescottes)
try looks green, sans parseable-css.js which looks like my fault > 0:19.21 TEST_END: Test OK. Subtests passed 0/2. Unexpected 2 > FAIL Got error message for chrome://devtools/skin/fonts.css: Error in parsing value for ‘flex-direction’. Declaration dropped. - > Stack trace: > chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:messageIsCSSError:248 > chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:439FAIL All the styles (104) loaded without errors. - Got 1, expected 0 > Stack trace: > chrome://mochikit/content/browser-test.js:test_is:1280 > chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:440
nevrmind, parseable-css.js is something checked into tree
Comment on attachment 8966684 [details] [diff] [review] rel-34.patch Review of attachment 8966684 [details] [diff] [review]: ----------------------------------------------------------------- LGTM!
Attachment #8966684 - Flags: review?(jdescottes) → review+
I'm sorry for the timing issues. I verified the regression in 34 locally. When I rebased the commit off of current inbound the timing issues went away.
Flags: needinfo?(jlaster)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cedd9712c8bca3fc7240e206b84ab40b2ead79bc first 1/2 of commits 0aeeee8 Remove all references to Firebug theme (#5883) 1d3f6ba [Sources] Auto expand path of selected source (#5716) b15c280 Prevent selection of breakpoint contents (#5879) a460b03 [QuickOpen] Path is too wide #5860 (#5868) 211d16f Update wasmparser to the latest version
selective is probably not clear, what I meant to say was. this commit includes all of 34 sans those 3 commits for webpack roots, auto expand and preview showing all original files.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: