Closed
Bug 1453264
Opened 7 years ago
Closed 6 years ago
[meta] Remove nsIBrowserSearchService::currentEngine (in favour of defaultEngine)
Categories
(Firefox :: Search, enhancement, P3)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: standard8, Assigned: Siddhant085, Mentored)
References
Details
(Keywords: meta, Whiteboard: [fxsearch])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
nsIBrowserSearchService::currentEngine and nsIBrowserSearchService::defaultEngine are the same thing.
We should remove one of them. Currently, defaultEngine is listed as an alias for currentEngine in the interface file.
However I think it makes more sense to keep defaultEngine, as that's what we set in the UX, it fits closer to how we normally discuss the default engine, and it fits with nsIBrowserSearchService::originalDefaultEngine.
I'll set up some mentored bugs blocking this to get this transition done and the currentEngine interface removed.
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → standard8
Priority: -- → P3
Whiteboard: [fxsearch]
Reporter | ||
Comment 1•6 years ago
|
||
Siddhant is going to take a look at doing this.
Assignee: standard8 → dpsrkp.sid
Mentor: standard8
Assignee | ||
Comment 2•6 years ago
|
||
All instances of nsIBrowserSearchService::currentEngine have been replaced by nsIBrowserSearchService::defaultEngine. Dropping this variable now.
Reporter | ||
Comment 3•6 years ago
|
||
@Siddhant, Could you try rebasing the patch please? Landing just failed with:
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, "applying /tmp/tmpp_T3xj
unable to find 'browser/components/search/test/browser_oneOffHeader.js' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file browser/components/search/test/browser_oneOffHeader.js.rej
abort: patch failed to apply", '')
Flags: needinfo?(dpsrkp.sid)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74d97073c54b
Dropping nsIBrowserSearchService::currentEngine in favour of defaultEngine. r=Standard8
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(dpsrkp.sid)
Reporter | ||
Comment 5•6 years ago
|
||
Thank you.
Comment 6•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment 7•6 years ago
|
||
I see that this updated the XPIDL interface, but the UUID wasn't changed to indicate to binary components that it did. Can you do a followup?
Flags: needinfo?(dpsrkp.sid)
Updated•6 years ago
|
Flags: needinfo?(standard8)
Reporter | ||
Comment 8•6 years ago
|
||
We stopped the practice of bumping the uuid for interfaces a while back - we no longer do that.
Flags: needinfo?(standard8)
Flags: needinfo?(dpsrkp.sid)
Comment 9•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/bea035f1836519f3b8a30d24892ba24c8174c9d8
Port Bug 1453264 - Dropping nsIBrowserSearchService::currentEngine in favour of defaultEngine. r=Standard8
Updated•6 years ago
|
status-firefox61:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•