not sure about adding the ember test, curious what others think.

Comment on attachment 8967559 [details] [diff] [review] rel-36-2.patch Review of attachment 8967559 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. I have a few comments, but we can address them with a future release. talos: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=d5214296d58f8d992252ac7f09f83a48cb879128&newProject=try&newRevision=faeead73ae5228a0b0e39aa9a55366fa9ae75331&framework=1 ::: devtools/client/debugger/new/test/mochitest/browser.ini @@ +60,5 @@ > + examples/ember/quickstart/dist/assets/quickstart.js > + examples/ember/quickstart/dist/assets/quickstart.map > + examples/ember/quickstart/dist/assets/vendor.css > + examples/ember/quickstart/dist/assets/vendor.js > + examples/ember/quickstart/dist/assets/vendor.map Do we need anything on top of those 7 files to run the test? I'm not sure if we should keep the all the source to generate the test assets in m-c if that's the case? As opposed to being in a separate repo, referenced from the README. We can sort that out between this release and the next, I'm curious to know what other peers would suggest here. ::: devtools/client/debugger/new/test/mochitest/browser_dbg-ember-quickstart.js @@ +1,1 @@ > + This file might be looked at by people outside of devtools. Can we add license + comment ? Follow up in next release is fine. (other debugger mochitests are also missing license headers and a description)

Thanks, I think you're right that we can likely clean up the Ember test quite a bit. github.com/devtools-html/debugger.html/issues/5957 Yep, we're working on adding a linter for the licenses. github.com/devtools-html/debugger.html/issues/5958

Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/256d572bff47 Update Debugger Frontend v36. r=jdescottes