Closed Bug 1453645 Opened 7 years ago Closed 5 years ago

Custom changes to top-sites don't sync from desktop to desktop profiles

Categories

(Firefox :: Sync, defect, P3)

60 Branch
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: abenson, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached image sync_bug_top_sites.png (deleted) —
STR: Create a new Firefox profile and then sign into Firefox Accounts and sync. My previous Top Sites do not sync, which should include, their position and custom image. Verified that Preferences was checked in Sync settings.
We should Sync enough history so that organic and uncustomized top-sites should be somewhat consistent, but we certainly don't sync custom changes to them.
Blocks: syncmore
Summary: Signing into FxA on a new profile doesn't sync Top Sites (new tab) → Custom changes to top-sites don't sync
Priority: -- → P3
Aaron does your |browser.newtabpage.pinned| pref look the same on both computers after syncing?
(In reply to Edouard Oger [:eoger] from comment #2) > Aaron does your |browser.newtabpage.pinned| pref look the same on both > computers after syncing? Edouard, they look identical.
As of today, I never see firefox sync the "TOP SITES" / "PINNED SITE" on a new device sign-in. Bookmark and history do sync successfully. I always have to create pinned site manually on a new device/computer. Firefox version 61.0.2 for both mobile and desktop(MacOS).

(In reply to Mark Hammond [:markh] from comment #1)

We should Sync enough history so that organic and uncustomized top-sites
should be somewhat consistent, but we certainly don't sync custom changes to
them.

I think it would be a nice feature to be able to sync top sites across all devices

(In reply to Edouard Oger [:eoger] from comment #2)

Aaron does your |browser.newtabpage.pinned| pref look the same on both
computers after syncing?

I've also found that the browser.newtabpage.pinned from my laptop has synced over to my desktop, but it just seems to be ignored: the custom Top Sites I set up on my laptop do not appear when I open a new window on my desktop.

Further info: browser.newtabpage.pinned reset itself after quit/relaunch on my desktop. That reset value then synced back to my laptop, so I have now lost my custom Top Sites config altogether.

We believe this now works.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME

Not so sure. I'm just setting up a new desktop, logged into my Firefox account and boom, the new Firefox synced the default top sites back to my old Firefox, over-writing my custom pinned top sites.

As near as I can tell, Firefox does not save or sync Top Sites. Every device I have needs to have it's top sites recreated, and the changes are never synced nor saved. I am currently running Windows firefox 84.0.1 and android nightly 201219 17:00 build #2015782347, but it has never worked on any version.

This is not fixed. They are not synced. This is more than just an inconvenience as well. Top sites on desktop can have a separate Title from URL. This is not possible on mobile. I have a number of top sites which are just different ports on the same IP. I can't tell them apart on mobile as I can't edit them that way. It would't be an issue if the sync from desktop worked.

You might also look at the new bug (same problem as this) I reported for the android mobile version here: https://github.com/mozilla-mobile/fenix/issues/17211

It his not shown much activity, though. Not sure why this is not a hotter issue.

This bug was just about desktop. While history is synced (and thus things like "most visited" etc should work as expected) top-sites aren't synced between desktop and mobile platforms. Unfortunately this is trickier than it sounds, because each platform does it in a different way. The github issue linked in comment 12 is the appropriate place to track this for Android, so I'm going to leave this marked as working, but update the description to make it clear this bug is just for desktop.

Summary: Custom changes to top-sites don't sync → Custom changes to top-sites don't sync from desktop to desktop profiles
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: