Closed
Bug 1454055
Opened 7 years ago
Closed 6 years ago
See if the QI in nsFind::NextNode() can be removed
Categories
(Core :: Find Backend, enhancement, P5)
Core
Find Backend
Tracking
()
RESOLVED
FIXED
People
(Reporter: mccr8, Assigned: emilio)
References
Details
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from bug 1449670 comment #5)
> ::: toolkit/components/find/nsFind.cpp:663
> (Diff revision 1)
> > NS_ENSURE_SUCCESS(rv, rv);
> > if (!aStartPoint) {
> > aStartPoint = aSearchRange;
> > }
> >
> > content = do_QueryInterface(mIterator->GetCurrentNode());
>
> I wonder whether we can ditch this QI too. Followup, please.
|
||
Comment 1•7 years ago
|
||
Andrew, is this something you intended to look at? Perhaps it's a simple fix?
Flags: needinfo?(continuation)
Priority: -- → P5
|
Reporter | |
Comment 2•7 years ago
|
||
I'm not planning on working on this.
Bug 1449670 comment #5 I think describes the general way the fix would go, in the part "You could avoid this QI like so". You'd do something similar for this part of the code.
Flags: needinfo?(continuation)
|
||
Comment 3•6 years ago
|
||
This code went away in bug 1472529 as far as I can see.
Assignee: nobody → emilio
Status: NEW → RESOLVED
Closed: 6 years ago
Depends on: 1472529
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•