Nightly 61 x64 20180417100054 de_DE @ Debian Testing, KDE, Radeon RX480, 2560x1440 https://hg.mozilla.org/mozilla-central/graph/f94b64e0020225c71701930f193bd96c3ad1d150 includes > Bug 1454507. Avoid asserting that we don't end up with an empty result. r=mstange It changed the crash signature and crash reason from bug 1451458 to this one. fresh profile: gfx.webrender.all, gfx.webrender.blob.invalidation bp-c7aef5cb-9219-4cb6-b6d8-de3210180417 17.04.18 15:53 crashtest from bug 1451458 comment 18 bp-56f78f7c-bab5-42fb-a028-b99e40180417 17.04.18 15:53 crashtest from bug 1451458 comment 18 bp-971c8411-d6a4-4595-a2e7-e0ad00180417 17.04.18 15:52 STR bug 1451458 from comment 15 bp-b5d4b917-1f02-4962-866e-b6a340180417 17.04.18 15:52 STR bug 1451458 from comment 15 > assertion failed: index.reader.pos < index.reader.buf.len()

*STR from bug 1451458 comment 15

Yeah, I think this assertion just needs to go too.

Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/51fdcc41076f Remove remaining assert for empty blob images.

(In reply to Pulsebot from comment #3) > Pushed by jmuizelaar@mozilla.com: > https://hg.mozilla.org/integration/mozilla-inbound/rev/51fdcc41076f https://hg.mozilla.org/integration/mozilla-inbound/log/51fdcc41076f mozregression --repo mozilla-inbound --launch 51fdcc41076f --pref gfx.webrender.all:true gfx.webrender.blob.invalidation:true first good: Doesn't crash. :) mozregression --repo mozilla-inbound --launch 135f00f02937 --pref gfx.webrender.all:true gfx.webrender.blob.invalidation:true last bad: crash.

Backed out for browser-chrome leaks backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/393b0712839a81d77e5b1a67dcb34d59e0c28c36 push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=51fdcc41076f7b3f555af5a9a2b8cc35ead7650e&filter-searchStr=asan%20browser-chrome failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=174180995&repo=mozilla-inbound&lineNumber=3317 [task 2018-04-17T19:30:54.893Z] 19:30:54 ERROR - GECKO(2716) | ==2716==ERROR: LeakSanitizer: detected memory leaks [task 2018-04-17T19:30:54.894Z] 19:30:54 INFO - GECKO(2716) | Direct leak of 144 byte(s) in 1 object(s) allocated from: [task 2018-04-17T19:30:54.895Z] 19:30:54 INFO - GECKO(2716) | #0 0x4c1c93 in malloc /builds/worker/workspace/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:88:3 [task 2018-04-17T19:30:54.897Z] 19:30:54 INFO - GECKO(2716) | #1 0x4f26fd in moz_xmalloc /builds/worker/workspace/build/src/memory/mozalloc/mozalloc.cpp:70:17 [task 2018-04-17T19:30:54.898Z] 19:30:54 INFO - GECKO(2716) | #2 0x7f1311da9db8 in operator new /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mozalloc.h:156:12 [task 2018-04-17T19:30:54.900Z] 19:30:54 INFO - GECKO(2716) | #3 0x7f1311da9db8 in mozilla::BackgroundHangThread::ReportHang(mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator>) /builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp:512 [task 2018-04-17T19:30:54.901Z] 19:30:54 INFO - GECKO(2716) | #4 0x7f1311da8a37 in mozilla::BackgroundHangManager::RunMonitorThread() /builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp:408:26 [task 2018-04-17T19:30:54.902Z] 19:30:54 INFO - GECKO(2716) | #5 0x7f1311da8093 in mozilla::BackgroundHangManager::MonitorThread(void*) /builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp:79:49 [task 2018-04-17T19:30:54.902Z] 19:30:54 INFO - GECKO(2716) | #6 0x7f13238d647e in _pt_root /builds/worker/workspace/build/src/nsprpub/pr/src/pthreads/ptthread.c:201:5 [task 2018-04-17T19:30:54.903Z] 19:30:54 INFO - GECKO(2716) | #7 0x7f1327c496b9 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9) [task 2018-04-17T19:30:54.904Z] 19:30:54 INFO - GECKO(2716) | Indirect leak of 32 byte(s) in 1 object(s) allocated from: [task 2018-04-17T19:30:54.906Z] 19:30:54 INFO - GECKO(2716) | #0 0x4c1c93 in malloc /builds/worker/workspace/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:88:3 [task 2018-04-17T19:30:54.911Z] 19:30:54 INFO - GECKO(2716) | #1 0x4f26fd in moz_xmalloc /builds/worker/workspace/build/src/memory/mozalloc/mozalloc.cpp:70:17 [task 2018-04-17T19:30:54.912Z] 19:30:54 INFO - GECKO(2716) | #2 0x7f13065b08ca in Malloc /builds/worker/workspace/build/src/obj-firefox/dist/include/nsTArray.h:209:46 [task 2018-04-17T19:30:54.914Z] 19:30:54 INFO - GECKO(2716) | #3 0x7f13065b08ca in nsTArrayInfallibleAllocator::ResultTypeProxy nsTArray_base<nsTArrayInfallibleAllocator, nsTArray_CopyWithMemutils>::EnsureCapacity<nsTArrayInfallibleAllocator>(unsigned long, unsigned long) /builds/worker/workspace/build/src/obj-firefox/dist/include/nsTArray-inl.h:136 [task 2018-04-17T19:30:54.914Z] 19:30:54 INFO - GECKO(2716) | #4 0x7f13091ba1a7 in AppendElements<mozilla::HangEntry, nsTArrayInfallibleAllocator> /builds/worker/workspace/build/src/obj-firefox/dist/include/nsTArray.h:2246:47 [task 2018-04-17T19:30:54.916Z] 19:30:54 INFO - GECKO(2716) | #5 0x7f13091ba1a7 in AppendElements<mozilla::HangEntry, nsTArrayInfallibleAllocator, nsTArrayInfallibleAllocator> /builds/worker/workspace/build/src/obj-firefox/dist/include/nsTArray.h:1637 [task 2018-04-17T19:30:54.916Z] 19:30:54 INFO - GECKO(2716) | #6 0x7f13091ba1a7 in nsTArray_Impl /builds/worker/workspace/build/src/obj-firefox/dist/include/nsTArray.h:902 [task 2018-04-17T19:30:54.918Z] 19:30:54 INFO - GECKO(2716) | #7 0x7f13091ba1a7 in nsTArray /builds/worker/workspace/build/src/obj-firefox/dist/include/nsTArray.h:2331 [task 2018-04-17T19:30:54.919Z] 19:30:54 INFO - GECKO(2716) | #8 0x7f13091ba1a7 in mozilla::HangStack::HangStack(mozilla::HangStack const&) /builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders/mozilla/HangTypes.h:1074 [task 2018-04-17T19:30:54.919Z] 19:30:54 INFO - GECKO(2716) | #9 0x7f1311da9cf7 in HangDetails /builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders/mozilla/HangTypes.h:1281:9 [task 2018-04-17T19:30:54.921Z] 19:30:54 INFO - GECKO(2716) | #10 0x7f1311da9cf7 in mozilla::BackgroundHangThread::ReportHang(mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator>) /builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp:497 [task 2018-04-17T19:30:54.921Z] 19:30:54 INFO - GECKO(2716) | #11 0x7f1311da8a37 in mozilla::BackgroundHangManager::RunMonitorThread() /builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp:408:26 [task 2018-04-17T19:30:54.921Z] 19:30:54 INFO - GECKO(2716) | #12 0x7f1311da8093 in mozilla::BackgroundHangManager::MonitorThread(void*) /builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp:79:49 [task 2018-04-17T19:30:54.922Z] 19:30:54 INFO - GECKO(2716) | #13 0x7f13238d647e in _pt_root /builds/worker/workspace/build/src/nsprpub/pr/src/pthreads/ptthread.c:201:5 [task 2018-04-17T19:30:54.922Z] 19:30:54 INFO - GECKO(2716) | #14 0x7f1327c496b9 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9) [task 2018-04-17T19:30:54.922Z] 19:30:54 INFO - GECKO(2716) | Indirect leak of 16 byte(s) in 1 object(s) allocated from: [task 2018-04-17T19:30:54.923Z] 19:30:54 INFO - GECKO(2716) | #0 0x4c1c93 in malloc /builds/worker/workspace/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:88:3 [task 2018-04-17T19:30:54.930Z] 19:30:54 INFO - GECKO(2716) | #1 0x7f13065902e1 in Alloc /builds/worker/workspace/build/src/xpcom/string/nsSubstring.cpp:256:22 [task 2018-04-17T19:30:54.931Z] 19:30:54 INFO - GECKO(2716) | #2 0x7f13065902e1 in nsTSubstring<char>::MutatePrep(unsigned int, char**, mozilla::detail::StringDataFlags*) /builds/worker/workspace/build/src/xpcom/string/nsTSubstring.cpp:167 [task 2018-04-17T19:30:54.932Z] 19:30:54 INFO - GECKO(2716) | #3 0x7f13065a268b in nsTSubstring<char>::ReplacePrepInternal(unsigned int, unsigned int, unsigned int, unsigned int) /builds/worker/workspace/build/src/xpcom/string/nsTSubstring.cpp:230:8 [task 2018-04-17T19:30:54.933Z] 19:30:54 INFO - GECKO(2716) | #4 0x7f130659f098 in nsTSubstring<char>::Assign(char const*, unsigned int, std::nothrow_t const&) /builds/worker/workspace/build/src/xpcom/string/nsTSubstring.cpp:391:8 [task 2018-04-17T19:30:54.934Z] 19:30:54 INFO - GECKO(2716) | #5 0x7f130658c2b4 in nsTSubstring<char>::Assign(nsTSubstring<char> const&) /builds/worker/workspace/build/src/xpcom/string/nsTSubstring.cpp:442:8 [task 2018-04-17T19:30:54.935Z] 19:30:54 INFO - GECKO(2716) | #6 0x7f1311da9aff in nsTString /builds/worker/workspace/build/src/obj-firefox/dist/include/nsTString.h:97:11 [task 2018-04-17T19:30:54.935Z] 19:30:54 INFO - GECKO(2716) | #7 0x7f1311da9aff in HangDetails /builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders/mozilla/HangTypes.h:1277 [task 2018-04-17T19:30:54.936Z] 19:30:54 INFO - GECKO(2716) | #8 0x7f1311da9aff in mozilla::BackgroundHangThread::ReportHang(mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator>) /builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp:497 [task 2018-04-17T19:30:54.937Z] 19:30:54 INFO - GECKO(2716) | #9 0x7f1311da8a37 in mozilla::BackgroundHangManager::RunMonitorThread() /builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp:408:26 [task 2018-04-17T19:30:54.937Z] 19:30:54 INFO - GECKO(2716) | #10 0x7f1311da8093 in mozilla::BackgroundHangManager::MonitorThread(void*) /builds/worker/workspace/build/src/toolkit/components/backgroundhangmonitor/BackgroundHangMonitor.cpp:79:49 [task 2018-04-17T19:30:54.938Z] 19:30:54 INFO - GECKO(2716) | #11 0x7f13238d647e in _pt_root /builds/worker/workspace/build/src/nsprpub/pr/src/pthreads/ptthread.c:201:5 [task 2018-04-17T19:30:54.939Z] 19:30:54 INFO - GECKO(2716) | #12 0x7f1327c496b9 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9) [task 2018-04-17T19:30:54.939Z] 19:30:54 INFO - GECKO(2716) | ----------------------------------------------------- [task 2018-04-17T19:30:54.940Z] 19:30:54 INFO - GECKO(2716) | Suppressions used: [task 2018-04-17T19:30:54.941Z] 19:30:54 INFO - GECKO(2716) | count bytes template [task 2018-04-17T19:30:54.942Z] 19:30:54 INFO - GECKO(2716) | 1 16 libc.so [task 2018-04-17T19:30:54.942Z] 19:30:54 INFO - GECKO(2716) | 682 21696 nsComponentManagerImpl [task 2018-04-17T19:30:54.943Z] 19:30:54 INFO - GECKO(2716) | 51 10608 mozJSComponentLoader::LoadModule [task 2018-04-17T19:30:54.944Z] 19:30:54 INFO - GECKO(2716) | 611 17509 libfontconfig.so [task 2018-04-17T19:30:54.945Z] 19:30:54 INFO - GECKO(2716) | 20 880 _PR_Getfd [task 2018-04-17T19:30:54.946Z] 19:30:54 INFO - GECKO(2716) | 1 29 libglib-2.0.so [task 2018-04-17T19:30:54.947Z] 19:30:54 INFO - GECKO(2716) | ----------------------------------------------------- [task 2018-04-17T19:30:54.947Z] 19:30:54 INFO - GECKO(2716) | SUMMARY: AddressSanitizer: 192 byte(s) leaked in 3 allocation(s). [task 2018-04-17T19:30:55.113Z] 19:30:55 INFO - TEST-INFO | Main app process: exit 0 [task 2018-04-17T19:30:55.115Z] 19:30:55 INFO - TEST-INFO | LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS [task 2018-04-17T19:30:55.116Z] 19:30:55 INFO - TEST-INFO | LeakSanitizer | This can be done in testing/mozbase/mozrunner/mozrunner/utils.py [task 2018-04-17T19:30:55.117Z] 19:30:55 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at Malloc, nsTArray_base, AppendElements, AppendElements [task 2018-04-17T19:30:55.118Z] 19:30:55 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::BackgroundHangThread::ReportHang, mozilla::BackgroundHangManager::RunMonitorThread, mozilla::BackgroundHangManager::MonitorThread, _pt_root [task 2018-04-17T19:30:55.119Z] 19:30:55 ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, nsTSubstring

Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7b816219f708 Remove remaining assert for empty blob images.

Relanded because the leak doesn't seem to have been my fault: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ccdbf4252127a2d37a6d89dcb5e2542877f0eb9