Closed
Bug 1454908
Opened 7 years ago
Closed 7 years ago
27.4 - 75.49% sessionrestore_many_windows / tp5o_webext responsiveness (windows10-64, windows7-32) regression on push 50091ebf4918 (Tue Apr 17 2018)
Categories
(Core :: Graphics, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | blocking | verified |
People
(Reporter: igoldan, Assigned: florian)
References
Details
(Keywords: perf, regression, talos-regression)
Attachments
(1 file)
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
Talos has detected a Firefox performance regression from push:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f46b5589e6039eb12f9b750bb1f6fd4cd5699c22&tochange=50091ebf491862711c143ae5dfbbd26000103eb9
As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
75% sessionrestore_many_windows windows10-64 pgo e10s stylo 793.83 -> 1,393.08
73% sessionrestore_many_windows windows7-32 pgo e10s stylo 831.83 -> 1,439.33
65% sessionrestore_many_windows windows10-64 opt e10s stylo 894.08 -> 1,479.42
61% sessionrestore_many_windows windows7-32 opt e10s stylo 978.67 -> 1,572.83
37% tp5o_webext responsiveness windows7-32 pgo e10s stylo 0.87 -> 1.19
31% tp5o_webext responsiveness windows10-64 pgo e10s stylo 0.96 -> 1.25
29% tp5o_webext responsiveness windows10-64 opt e10s stylo 1.07 -> 1.37
27% tp5o_webext responsiveness windows7-32 opt e10s stylo 1.10 -> 1.40
You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=12758
On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.
To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Buildbot/Talos/Tests
For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Buildbot/Talos/Running
*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***
Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Buildbot/Talos/RegressionBugsHandling
Reporter | ||
Updated•7 years ago
|
Component: Untriaged → Graphics
Product: Firefox → Core
Reporter | ||
Comment 1•7 years ago
|
||
:florian Bug 1450293 looks to have caused these huge performance regressions. Must we back it out or can we resolve this?
Flags: needinfo?(florian)
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #1)
> Must we back it out or can we resolve this?
I don't know yet, but investigating this is my top priority. It was already reported yesterday as bug 1454638 which I believe is the same problem, but seen from user perception rather than Talos numbers.
Updated•7 years ago
|
Assignee: nobody → florian
Severity: normal → blocker
status-firefox59:
--- → unaffected
status-firefox60:
--- → unaffected
status-firefox61:
--- → affected
status-firefox-esr52:
--- → unaffected
tracking-firefox61:
--- → blocking
Flags: needinfo?(florian)
Priority: -- → P1
Assignee | ||
Comment 3•7 years ago
|
||
This solves locally the problem I had observed in the profiles from bug 1454638. I'm waiting for try results before requesting review.
Assignee | ||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8968903 [details] [diff] [review]
Patch
This patch matches what is already done in 2 other places in the same method: https://searchfox.org/mozilla-central/rev/f65d7528e34ef1a7665b4a1a7b7cdb1388fcd3aa/widget/windows/nsWindowGfx.cpp#188-190,196-198,245-248
Attachment #8968903 -
Attachment description: Tentative patch → Patch
Attachment #8968903 -
Flags: review?(jmathies)
Updated•7 years ago
|
Attachment #8968903 -
Flags: review?(jmathies) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be9efc84b582
do an empty paint when skipping the actual paint for the blank window, to stop Windows from sending messages repeatedly, r=jimm.
Comment 8•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Reporter | ||
Comment 9•6 years ago
|
||
I confirm the fix:
== Change summary for alert #12810 (as of Wed, 18 Apr 2018 16:46:08 GMT) ==
Improvements:
42% sessionrestore_many_windows windows10-64 pgo e10s stylo 1,392.33 -> 808.00
41% sessionrestore_many_windows windows7-32 pgo e10s stylo 1,435.92 -> 848.00
39% sessionrestore_many_windows windows10-64 opt e10s stylo 1,475.75 -> 904.00
36% sessionrestore_many_windows windows7-32 opt e10s stylo 1,567.08 -> 995.25
23% tp5o_webext responsiveness windows10-64 pgo e10s stylo 1.21 -> 0.93
23% tp5o_webext responsiveness windows7-32 opt e10s stylo 1.40 -> 1.08
23% tp5o_webext responsiveness windows7-32 pgo e10s stylo 1.18 -> 0.91
21% tp5o_webext responsiveness windows10-64 opt e10s stylo 1.34 -> 1.06
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=12810
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•