This is for enabling the `layers.enable-tiles-if-skia-pomtp` and `layers.omtp.paint-workers` prefs on windows on nightly. Note: these prefs will only have effect on users that are using skia (AKA not hardware accelerated). You can opt into this by setting `gfx.direct2d.disabled` to true.

(In reply to Ryan Hunt [:rhunt] from comment #0) > This is for enabling the `layers.enable-tiles-if-skia-pomtp` and > `layers.omtp.paint-workers` prefs on windows on nightly. > Boom!! bp-7106396a-f342-40f4-a678-087d90180418

(In reply to Ekanan Ketunuti from comment #1) > (In reply to Ryan Hunt [:rhunt] from comment #0) > > This is for enabling the `layers.enable-tiles-if-skia-pomtp` and > > `layers.omtp.paint-workers` prefs on windows on nightly. > > > > Boom!! bp-7106396a-f342-40f4-a678-087d90180418 and bp-7011586a-5171-46b0-acdd-3108d0180419

(In reply to Ekanan Ketunuti from comment #2) > (In reply to Ekanan Ketunuti from comment #1) > > (In reply to Ryan Hunt [:rhunt] from comment #0) > > > This is for enabling the `layers.enable-tiles-if-skia-pomtp` and > > > `layers.omtp.paint-workers` prefs on windows on nightly. > > > > > > > Boom!! bp-7106396a-f342-40f4-a678-087d90180418 > > and bp-7011586a-5171-46b0-acdd-3108d0180419 Those look like they're from some incomplete code in gfxPlatform for pref configuration. That will be fixed. https://treeherder.mozilla.org/#/jobs?repo=try&revision=200b0791d242272ce8dd78221e4ed746509a39d4 I was able to figure out what was causing the try assertion, it looks like a race condition in SourceSurfaceSkia. Nothing that would actually affect anyone though, it would just hit the assertion. There are some fuzzy value changes that will need to happen. I have a patch written but realized that as this will only be enabled in nightly once this goes the beta those fuzzy value changes will be out of date and start causing failures. So I need to think about that a little more. The rest can be reviewed now though.

Comment on attachment 8971050 [details] Bug 1454978 - Move MOZ_ASSERT(mIsMapped) into mChangeMutex. https://reviewboard.mozilla.org/r/239782/#review245892 Should this really be a release assert?

Comment on attachment 8971051 [details] Bug 1454978 - Cleanup tiling prefs in all.js. https://reviewboard.mozilla.org/r/239784/#review245894

Comment on attachment 8971052 [details] Bug 1454978 - Make OMTP feature detection not depend on tiling. https://reviewboard.mozilla.org/r/239786/#review245896

Comment on attachment 8971053 [details] Bug 1454978 - Enable tiled parallel OMTP when we are using skia on windows on nightly. https://reviewboard.mozilla.org/r/239788/#review245898

(In reply to Bas Schouten (:bas.schouten) from comment #8) > Comment on attachment 8971050 [details] > Bug 1454978 - Move MOZ_ASSERT(mIsMapped) into mChangeMutex. > > https://reviewboard.mozilla.org/r/239782/#review245892 > > Should this really be a release assert? No it shouldn't, that should've been reverted back. I'll fix that.

Comment on attachment 8971694 [details] Bug 1454978 - Update test fuzziness. https://reviewboard.mozilla.org/r/240462/#review246416

Pushed by rhunt@eqrion.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/4317518ef415 Move MOZ_ASSERT(mIsMapped) into mChangeMutex. r=bas https://hg.mozilla.org/integration/mozilla-inbound/rev/0caaa2b6f3a0 Cleanup tiling prefs in all.js. r=bas https://hg.mozilla.org/integration/mozilla-inbound/rev/2ba500ed529b Make OMTP feature detection not depend on tiling. r=bas https://hg.mozilla.org/integration/mozilla-inbound/rev/a9f8c9c32b95 Enable tiled parallel OMTP when we are using skia on windows on nightly. r=bas https://hg.mozilla.org/integration/mozilla-inbound/rev/c460245ddcff Update test fuzziness. r=bas

https://hg.mozilla.org/mozilla-central/rev/4317518ef415 https://hg.mozilla.org/mozilla-central/rev/0caaa2b6f3a0 https://hg.mozilla.org/mozilla-central/rev/2ba500ed529b https://hg.mozilla.org/mozilla-central/rev/a9f8c9c32b95 https://hg.mozilla.org/mozilla-central/rev/c460245ddcff