Closed
Bug 1455151
Opened 7 years ago
Closed 7 years ago
Support subdialog sizing of HTML documents from a stylesheet and use it for autofill edit dialogs
Categories
(Firefox :: Settings UI, enhancement, P1)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [webpayments])
Attachments
(1 file)
Setting width/max-width on `html` or `body` from a stylesheet for a HTML document doesn't currently work for sizing the subdialog which means that @width or @style="width: NNNpx" on `html` is necessary. That works okay except that it means that it requires allowing inline styles via CSP which isn't great since you can't allow only certain properties.
For Web Payments we re-use editAddress.xhtml and editCreditCard.xhtml outside of the subdialog in the PaymentRequest dialog and want to have a strict CSP to prevent inline styles so we currently get CSP errors on every load.
Checking the scrollWidth on the body (for HTML documents, where the <body> exists) works.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8969124 [details]
Bug 1455151 - Support subdialog sizing of HTML documents from a stylesheet and use it for autofill edit dialogs.
https://reviewboard.mozilla.org/r/237836/#review243560
Attachment #8969124 -
Flags: review?(jaws) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/b180b277a1ef
Support subdialog sizing of HTML documents from a stylesheet and use it for autofill edit dialogs. r=jaws
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•