Closed
Bug 1455392
Opened 7 years ago
Closed 7 years ago
Remove checkState from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement
Categories
(Core :: XUL, task)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(3 files)
This is only ever used to check for CHECKSTATE_MIXED which in turn is used to set mozilla::a11y::states::MIXED
- https://searchfox.org/mozilla-central/search?q=%3A%3Acheckstate&path=
However, there's only one place we ever set that state - in the about:addons 'Recent Updates' list. The mixed state is set when the list is ascending, which doesn't seem right. The element is 'checked' whether it's ascending or descending. https://searchfox.org/mozilla-central/rev/59a9a86553e9bfd9277202748ff791fd9bc0713b/toolkit/mozapps/extensions/content/extensions.xml#302
If we get rid of that consumer, I believe we can remove all the idl and accessibility code handling this case, which should help unblock switching to an actual html:input (since the only remaining attribute on nsIDOMXULCheckboxElement.idl after this and Bug 1455359 will be 'checked').
Assignee | ||
Comment 1•7 years ago
|
||
Andrew - we could update the checkState to always be '1' for the selected header. But.. could we just remove this UI? The default sort order is by Date (most recent first) which seems like the correct order for a 'recent updates' list.
Flags: needinfo?(aswan)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8969410 [details]
Bug 1455392 - Remove checkState from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement
https://reviewboard.mozilla.org/r/238164/#review243884
r=me for a11y part
Attachment #8969410 -
Flags: review?(surkov.alexander) → review+
Comment 5•7 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #1)
> Andrew - we could update the checkState to always be '1' for the selected
> header. But.. could we just remove this UI? The default sort order is by
> Date (most recent first) which seems like the correct order for a 'recent
> updates' list.
Works for me, ccing Emanuela and Markus from UX so they are not surprised.
Odds are high that somebody will pop up in the next few weeks and say that they have a hundred extensions installed and now they can't effectively find things in recent updates, but I don't think that should stand in the way of de-XBLing
Flags: needinfo?(aswan)
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8969409 [details]
Bug 1455392 - Remove sortable UI in about:addons recent updates;
https://reviewboard.mozilla.org/r/238162/#review243886
Attachment #8969409 -
Flags: review?(aswan) → review+
Assignee | ||
Comment 7•7 years ago
|
||
For reference - this is the UI we are talking about
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 10•7 years ago
|
||
Comment on attachment 8969410 [details]
Bug 1455392 - Remove checkState from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement
Requesting review for the dom idl changes
Attachment #8969410 -
Flags: review?(bzbarsky)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8969410 [details]
Bug 1455392 - Remove checkState from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement
https://reviewboard.mozilla.org/r/238164/#review244262
r=me, but you don't have to rev iids...
Attachment #8969410 -
Flags: review?(bzbarsky) → review+
Comment 14•7 years ago
|
||
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a24709c044b
Remove sortable UI in about:addons recent updates;r=aswan
https://hg.mozilla.org/integration/autoland/rev/e166407fe8b0
Remove checkState from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement;r=bz,surkov
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8a24709c044b
https://hg.mozilla.org/mozilla-central/rev/e166407fe8b0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 16•7 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•