Closed
Bug 1455841
Opened 7 years ago
Closed 7 years ago
Tab loading throbber doesnt throb while page is loading
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | --- | disabled |
People
(Reporter: mayankleoboy1, Assigned: hiro)
References
()
Details
(Keywords: nightly-community, regression)
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180421100143
Steps to reproduce:
Create new profile.
Enable WR. Restart browser.
Go to https://jwatt.org/tmp/load-never-finishes.php
Actual results:
the throbber in the tab is "stuck"
Expected results:
not so
Reporter | ||
Comment 1•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Comment 2•7 years ago
|
||
Thank you!
Nightly 61 x64 20180421100143 de_DE dd0e54d786743974a50a338059bcd68a09b6d5b2 @ Debian Testing (KDE, Radeon RX480)
Now I got the update and can reproduce. (Next time I'll directly try the latest inbound build without waiting.)
mozregression --good 2018-04-20 --bad dd0e54d786743974a50a338059bcd68a09b6d5b2 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://jwatt.org/tmp/load-never-finishes.php'
> 7:48.33 INFO: Last good revision: d1bcd80c9a73a647a583958bef60816ae90d3d6b
> 7:48.33 INFO: First bad revision: b758bc75b0549db2d047539663c98f6f87ffd19b
> 7:48.33 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d1bcd80c9a73a647a583958bef60816ae90d3d6b&tochange=b758bc75b0549db2d047539663c98f6f87ffd19b
> b758bc75b054 Hiroyuki Ikezoe — Bug 1455315 - Use testing time stamp whenever we are on testing mode. r=kats
Blocks: 1455315
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox59:
--- → unaffected
status-firefox60:
--- → unaffected
status-firefox61:
--- → disabled
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Ever confirmed: true
Keywords: nightly-community,
regression
OS: Unspecified → All
Comment 3•7 years ago
|
||
Mozregression points to your change. Could you have a look, please?
Flags: needinfo?(hikezoe)
Comment 4•7 years ago
|
||
Same regression range: https://bug1401665.bmoattachments.org/attachment.cgi?id=8910415
Actual: The circle only rotates if you move the mouse. (And after doing unknown steps it doesn't even do that.)
Expected: It should permanently rotate.
Comment 5•7 years ago
|
||
In new code, when animTime = mPreviousFrameTimeStamp, line 1185 shows different result from old code.
Old code:
mPreviousFrameTimeStamp always becomes mCompositorScheduler->GetLastComposeTime() or cbp->GetTestingTimeStamp().ref() even if mPreviousFrameTimeStamp was sent to SampleAnimations.
New code:
mPreviousFrameTimeStamp can be unchanged when animTime = mPreviousFrameTimeStamp.
Is this intended?
Assignee | ||
Comment 6•7 years ago
|
||
Definitely not! I made a silly mistake.
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Flags: needinfo?(hikezoe)
Assignee | ||
Comment 7•7 years ago
|
||
The code I wrote in bug 1455315 was pretty error-prone. Sorry about that.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d70fb6bee45101ce6a96a13257629afb9f04fc46
Comment 9•7 years ago
|
||
Works fine with try build.
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8970036 [details]
Bug 1455841 - Don't update mPreviousFrameTimeStamp in the case of testing refresh mode.
https://reviewboard.mozilla.org/r/238786/#review244488
Is it possible to write a test that exercises this behavior? It's kind of bad that we don't have a test that caught this.
Attachment #8970036 -
Flags: review?(bugmail) → review+
Assignee | ||
Comment 12•7 years ago
|
||
Yeah, totally agree. I am surprised that no tests didn't catch this. I have no idea about the test case for now, but I keep thinking how to do that.
Comment 13•7 years ago
|
||
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f6ffc8378e3
Don't update mPreviousFrameTimeStamp in the case of testing refresh mode. r=kats
Assignee | ||
Comment 14•7 years ago
|
||
Oh, I didn't realize that dom/animation/test/mozilla/test_deferred_start.html is skipped on WebRender unfortunately. And also there should be test cases in layout/style/test but maybe all of them are disabled on WebRender now.
Comment 15•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•