Closed
Bug 1456158
Opened 7 years ago
Closed 7 years ago
Add schema / propTypes for AS Router Simple Snippet template
Categories
(Firefox :: Messaging System, enhancement, P2)
Firefox
Messaging System
Tracking
()
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: k88hudson, Assigned: k88hudson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
We need a way to indicate the set of variables that are available to templates in order to
(a) validate messages that are being displayed
(b) provide something that is readable by the Snippets Service in order to create appropriate admin UI
I was thinking JSON schema might be a good option since there is pretty wide support for it in JS/Python, but it could be something else
For our 61 experiment, the schema should match the existing one in https://github.com/mozmeao/snippets/blob/master/activity-stream/simple-snippet.html#L4
Assignee | ||
Updated•7 years ago
|
Iteration: --- → 61.4 - May 7
Priority: -- → P2
Assignee | ||
Updated•7 years ago
|
Severity: normal → enhancement
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → khudson
Updated•7 years ago
|
Iteration: 61.4 - May 7 → 62.1 - May 21
Assignee | ||
Updated•7 years ago
|
Iteration: 62.1 - May 21 → 62.2 - Jun 4
Assignee | ||
Updated•7 years ago
|
Iteration: 62.2 - Jun 4 → 62.1 - May 21
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/e653af476c770ab0b797a44efc1eeb521fef6c99
Bug 1456158 - Add schema for AS Router Simple Snippet template
https://github.com/mozilla/activity-stream/commit/e2b091726703f3c806222aff26d5a38603c72ddb
Merge pull request #4153 from k88hudson/bug1456158
Bug 1456158 - Add schema for AS Router Simple Snippet template
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 3•7 years ago
|
||
status-firefox62:
--- → fixed
Target Milestone: --- → Firefox 62
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•