Closed
Bug 1456254
Opened 7 years ago
Closed 7 years ago
onNewSession() is broken
Categories
(GeckoView :: General, defect, P1)
Tracking
(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox59 wontfix, firefox60 wontfix, firefox61 fixed)
RESOLVED
FIXED
mozilla61
People
(Reporter: snorp, Assigned: snorp)
References
Details
Attachments
(1 file)
onNewSession() is correctly called, but nothing is loaded into a returned session. With e10s.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → snorp
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8971058 [details]
Bug 1456254 - Correctly set nextTabParentId in GeckoView
https://reviewboard.mozilla.org/r/239800/#review245728
::: mobile/android/modules/geckoview/GeckoViewNavigation.jsm:99
(Diff revision 1)
> // Message manager event handler.
> receiveMessage(aMsg) {
> debug `receiveMessage: ${aMsg.name}`;
> }
>
> - waitAndSetOpener(aSessionId, aOpener) {
> + waitAndSetupWindow(aSessionId, { opener, nextTabParentId }) {
I'm not sure whether unpacked arguments should have the a-prefix.
Attachment #8971058 -
Flags: review?(esawin) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Eugen Sawin [:esawin] from comment #2)
> Comment on attachment 8971058 [details]
> Bug 1456254 - Correctly set nextTabParentId in GeckoView
>
> https://reviewboard.mozilla.org/r/239800/#review245728
>
> ::: mobile/android/modules/geckoview/GeckoViewNavigation.jsm:99
> (Diff revision 1)
> > // Message manager event handler.
> > receiveMessage(aMsg) {
> > debug `receiveMessage: ${aMsg.name}`;
> > }
> >
> > - waitAndSetOpener(aSessionId, aOpener) {
> > + waitAndSetupWindow(aSessionId, { opener, nextTabParentId }) {
>
> I'm not sure whether unpacked arguments should have the a-prefix.
I think not, since they're properties of an object -- but I'm also against the 'a' prefix in general.
|
|
||
Comment 4•7 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #3)
> I think not, since they're properties of an object -- but I'm also against
> the 'a' prefix in general.
Yeah, I've grown tired of it in JS code, too. We should consider switching away over time.
|
||
Updated•7 years ago
|
status-firefox59:
--- → wontfix
status-firefox60:
--- → wontfix
status-firefox61:
--- → affected
status-firefox-esr52:
--- → wontfix
status-firefox-esr60:
--- → wontfix
Priority: -- → P1
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de23cd2fcc4a
Correctly set nextTabParentId in GeckoView r=esawin
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Version: Firefox 59 → 59 Branch
|
|
||
Updated•6 years ago
|
Target Milestone: Firefox 61 → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•