Closed
Bug 1456307
Opened 7 years ago
Closed 6 years ago
Replace Flexbox icon with new more accurate Flexbox icon
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: victoria, Assigned: fvsch)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
Attached is an icon that looks more like the flexbox overlay itself and hopefully represents a more common case for flexboxes
Updated•7 years ago
|
Blocks: dt-flexbox
Priority: -- → P3
Updated•7 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
Updated•6 years ago
|
Product: Firefox → DevTools
Comment 2•6 years ago
|
||
Hey Victoria,
The SVGs for this Flexbox icon is a bit hard to work with. Can you provide an SVG that is similarly formatted like in Bug 1465649.
Flags: needinfo?(victoria)
Updated•6 years ago
|
Assignee: gl → nobody
Status: ASSIGNED → NEW
Reporter | ||
Comment 3•6 years ago
|
||
I was able to get the code looking a lot simpler after opening in Illustrator and deleting excess layers. Let me know if this still has issues.
Attachment #8970379 -
Attachment is obsolete: true
Flags: needinfo?(victoria)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → florens
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•6 years ago
|
||
I'll do this one, and try to rebase bug 1490491 afterwards.
Assignee | ||
Comment 5•6 years ago
|
||
I handwrote the SVG to save a few more bytes, and I'm getting this result.
It looks alright, except in the case where we click the icon and the icon+label group gets a focusring, which uses a dotted style. Since we have a dotted style in the icon itself, it can look a bit messy.
Should we try a different style for the outer rectangle, for instance a solid stroke at 50% opacity?
Assignee | ||
Comment 6•6 years ago
|
||
Tried a solid line at 50% opacity and it's not much better (and loses the metaphor of the flexbox overlay which uses dashes for the parent). Also tried using dashes rather than dots (dashoffset of "2 1" or "3 1") but couldn't make it work with the 13x11 dimensions. Leaving it as is for now.
Maybe the solution is in using :-moz-focusring instead of :focus styles for focus rings on property names and values?
(And pushing for the standardized :focus-visible in Firefox too.)
Assignee | ||
Comment 7•6 years ago
|
||
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a871d40e8802
Use more accurate flexbox icon in inspector; r=pbro
Comment 9•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Reporter | ||
Comment 10•6 years ago
|
||
I've been meaning to file a tools-wide bug re: showing button focus rings only when tabbed to via keyboard, and not for mouse clicks -- I think that would be a good solution here as well. (The Debugger team started to do this for their stepping buttons.)
A bit of a tangent: The toggled on status is kind of hard to see, so I've also been working on a white-on-blue style for when these types of buttons are toggled on, though it starts to get weirdly similar to the markup view badges.
(General improvement of focus rings on keyboard nav is still on my todo list for later, as I'd like to abolish the dotted line look everywhere :D but I'm hoping for now we could just be a bit more selective about when these focus rings show up.)
You need to log in
before you can comment on or make changes to this bug.
Description
•